8000 Add Support for RTL text in lyrics by devceline · Pull Request #749 · aome510/spotify-player · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Support for RTL text in lyrics #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 22, 2025
Merged

Add Support for RTL text in lyrics #749

merged 4 commits into from
Jun 22, 2025

Conversation

devceline
Copy link
Contributor
@devceline devceline commented Jun 18, 2025 •
edited
Loading

Changes

  • Adds per-line RTL text detection and formatting.
  • Adds new dependency unicode-bidi

Note: Using unicode_bidi instead of just reversing the line also allows for properly formatting line with multi-lingual words.

Screenshot

image

Testing

Example Songs:

Tested on:

  • Ghostty
  • Kitty
  • Alacritty

Resolves #750

@devceline devceline marked this pull request as ready for review June 18, 2025 17:50
@JamesManningR
Copy link
Contributor
JamesManningR commented Jun 19, 2025 •
edited
Loading

Added context: this is how those same lines look in the spotify app
Screenshot 2025-06-19 at 12 34 21

@aome510 aome510 merged commit 6f60959 into aome510:master Jun 22, 2025
5 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jun 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aome510 aome510 aome510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTL text is misformatted in lyrics
3 participants
@devceline @JamesManningR @aome510
0