Add actions to keymap configuration #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 20, 2024 19:17
All action logic here remains the same
I'm not sure if this is the best way to do this, or even necessary but i could't find another easy way to get the current relevant data for whatever is under the cursor
|
Nice! Thanks for the PR. I'll take a look this weekend 👀 |
aome510
reviewed
Jun 22, 2024
There was a problem hiding this comment.
I just realized #428 is not really good first issue as I originally labeled it to be. I'm really impressed about how quickly you picked up the codebase and implemented such a non-trivial feature.
Anyway, great work! Mostly look good to me.
Co-authored-by: Thang Pham <phamducthang1234@gmail.com>
Co-authored-by: Thang Pham <phamducthang1234@gmail.com>
aome510
reviewed
Jun 23, 2024
Co-authored-by: Thang Pham <phamducthang1234@gmail.com>
aome510
approved these changes
Jun 23, 2024
Co-authored-by: Thang Pham <phamducthang1234@gmail.com>
|
Thank you for your patience, and this awesome project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #428
Since this PR is quite large i split it up into smaller commits to hopefully make it easier to understand.
The AddSelectedItemToQueue command could now be removed and replaced with an action keymap, although this might break some people's configurations.