8000 fix:#3513 切换节点文字位置,文字位置出现错误 by daichaofan · Pull Request #3531 · antvis/G6 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix:#3513 切换节点文字位置,文字位置出现错误 #3531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

daichaofan
Copy link
Contributor
Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

@cliffordfajardo
Copy link
Contributor

@daichaofan - it might be a good idea to add a small test or check in case this happens again in a future code version
what do you think?

@Yanyan-Wang
Copy link
Contributor

如果能在 tests/unit 中增加一些测试用例就更好了~

争取跟下次小版本发布发车

@Yanyan-Wang Yanyan-Wang changed the base branch from master to combo-perf-0110 March 3, 2022 03:40
@Yanyan-Wang Yanyan-Wang merged commit 4310716 into antvis:combo-perf-0110 Mar 3, 2022
Yanyan-Wang added a commit that referenced this pull request Mar 3, 2022
…ons for any situations; 4.6.0-beta (#3510)

* docs: add indented tree and brief node demos

* feat: combo supports being assigned positions

* fix: run layout promise only when the layout is configured;

* chore: rebase and version number unpdate

* chore: upgrade

* chore: refine

* chore: refine

* fix: no animate when a node has no previous position

* fix: fix the hidden combos not set correctly (#3509)

close #3508

* chore: update version

* chore: register dagreCompound layout (#3548)

* fix: #3513 切换节点文字位置,文字位置出现错误 (#3531)

Co-authored-by: daichaofan <daichaofan@139.com>

* chore: update versions

Co-authored-by: simplejason <simplejason.coder@gmail.com>
Co-authored-by: daichaofan <50311886+daichaofan@users.noreply.github.com>
Co-authored-by: daichaofan <daichaofan@139.com>
Yanyan-Wang added a commit that referenced this pull request Jun 13, 2022
…ons for any situations; 4.6.0-beta (#3510)

* docs: add indented tree and brief node demos

* feat: combo supports being assigned positions

* fix: run layout promise only when the layout is configured;

* chore: rebase and version number unpdate

* chore: upgrade

* chore: refine

* chore: refine

* fix: no animate when a node has no previous position

* fix: fix the hidden combos not set correctly (#3509)

close #3508

* chore: update version

* chore: register dagreCompound layout (#3548)

* fix: #3513 切换节点文字位置,文字位置出现错误 (#3531)

Co-authored-by: daichaofan <daichaofan@139.com>

* chore: update versions

Co-authored-by: simplejason <simplejason.coder@gmail.com>
Co-authored-by: daichaofan <50311886+daichaofan@users.noreply.github.com>
Co-authored-by: daichaofan <daichaofan@139.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0