Automated cherry pick of #7230: Fix race condition when getting metrics #7236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnqn
reviewed
Jun 19, 2025
pkg/flowaggregator/flowaggregator.go
Outdated
| metrics := querier.Metrics{ | ||
| NumRecordsExported: fa.numRecordsExported.Load(), | ||
| NumRecordsReceived: fa.collectingProcess.GetNumRecordsReceived(), | ||
| NumFlows: fa.getNumFlows(), |
There was a problem hiding this comment.
addressed, thanks
The 2 int64 counters (numRecordsExported and numRecordsDropped) are changed to atomic.Int64. Access to the exporter pointers is protected by a mutex. It need to be locked in UpdateOptions and GetRecordMetrics). Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
60ed2d2 to
20c9a00
Compare
|
/test-all |
tnqn
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #7230 on release-2.2.
#7230: Fix race condition when getting metrics
For details on the cherry pick process, see the cherry pick requests page.