8000 [Not4Review]Change to include unit test data only by luolanzone · Pull Request #4616 · antrea-io/antrea · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Not4Review]Change to include unit test data only #4616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Not4Review]Change to include unit test data only #4616

wants to merge 1 commit into from

Conversation

luolanzone
Copy link
Contributor

The purpose of this PR is to track latest unit test coverage data on Codecov.

Signed-off-by: Lan Luo luola@vmware.com

@luolanzone luolanzone force-pushed the codecov-ut-only branch 3 times, most recently from a287c05 to b0aa950 Compare February 9, 2023 07:52
@codecov
Copy link
codecov bot commented Feb 9, 2023 •
edited
Loading

Codecov Report

Merging #4616 (b0aa950) into main (6d76ddf) will increase coverage by 1.45%.
The diff coverage is n/a.

❗ Current head b0aa950 differs from pull request most recent head bf9eeb5. Consider uploading reports for the commit bf9eeb5 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4616      +/-   ##
==========================================
+ Coverage   68.64%   70.10%   +1.45%     
==========================================
  Files         400      376      -24     
  Lines       59450    57192    -2258     
==========================================
- Hits        40809    40092     -717     
+ Misses      15807    14341    -1466     
+ Partials     2834     2759      -75
Flag Coverage Δ *Carryforward flag
e2e-tests 38.34% <ø> (ø) Carriedforward from 6d76ddf
integration-tests 34.53% <ø> (ø) Carriedforward from 6d76ddf
kind-e2e-tests 40.46% <ø> (ø) Carriedforward from 6d76ddf
unit-tests 60.84% <ø> (+1.08%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
pkg/features/antrea_features.go 64.00% <0.00%> (-36.00%) ⬇️
pkg/apiserver/handlers/endpoint/handler.go 56.52% <0.00%> (-13.05%) ⬇️
cmd/antrea-agent/options.go 31.99% <0.00%> (-4.98%) ⬇️
pkg/util/env/env.go 58.73% <0.00%> (-4.77%) ⬇️
pkg/antctl/runtime/runtime.go 33.33% <0.00%> (-3.34%) ⬇️
...catesigningrequest/ipsec_csr_signing_controller.go 61.65% <0.00%> (-2.46%) ⬇️
pkg/agent/cniserver/ipam/ipam_service.go 81.72% <0.00%> (-2.16%) ⬇️
pkg/controller/externalippool/controller.go 84.37% <0.00%> (-1.79%) ⬇️
pkg/flowaggregator/flowaggregator.go 71.49% <0.00%> (-1.54%) ⬇️
...gent/controller/noderoute/node_route_controller.go 66.91% <0.00%> (-1.37%) ⬇️
... and 29 more

@luolanzone luolanzone mentioned this pull request Feb 9, 2023
Closed
@wenqiq
Copy link
Contributor
wenqiq commented Feb 10, 2023

There is already a branch codecov-ut created by PR #4310 in codecov(https://app.codecov.io/gh/antrea-io/antrea/tree/codecov-ut) and I think it’s not needed to create a new branch just for tracking the latest unit test coverage.

@luolanzone
Copy link
Contributor Author

@wenqiq I think it's better to use a branch in antrea repo instead of a personal branch to track the unit test coverage considering it will be a long running PR. I have also removed unused github workflows to avoid unnecessary runner resource usage. You can update the branch codecov-ut-only in the future directly.

@luolanzone luolanzone force-pushed the codecov-ut-only branch 2 times, most recently from f9b72fc to 2933e97 Compare February 23, 2023 10:16
@rajnkamr rajnkamr force-pushed the codecov-ut-only branch 4 times, most recently from 7792b00 to c001763 Compare March 17, 2023 13:58
@rajnkamr rajnkamr force-pushed the codecov-ut-only branch 2 times, most recently from f3c5e0a to 743ef4c Compare April 6, 2023 05:42
@rajnkamr rajnkamr force-pushed the codecov-ut-only branch from 3d9e695 to 60610c0 Compare May 4, 2023 10:19
@rajnkamr rajnkamr force-pushed the codecov-ut-only branch 2 times, most recently from 46fe043 to 745523d Compare June 8, 2023 14:52
@rajnkamr rajnkamr force-pushed the codecov-ut-only branch 2 times, most recently from 12e96f4 to e13e355 Compare July 25, 2024 16:09
@antrea-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@CodiumAI-Agent
Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@rajnkamr rajnkamr force-pushed the codecov-ut-only branch from 9d82d8d to 3aeb5e6 Compare May 5, 2025 05:06
@luolanzone @rajnkamr
Change to include unit test data only
6e978a9 
Signed-off-by: Rajnish K <rajnishk1@vmware.com>
Signed-off-by: Lan Luo <luola@vmware.com>
Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodiumAI-Agent CodiumAI-Agent CodiumAI-Agent left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luolanzone @wenqiq @CodiumAI-Agent @rajnkamr @antrea-bot
0