fix(ui): ensure command registration occurs after workflow initialization #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core Functionality Improvement
This PR fixes a critical timing issue in the UI initialization process, ensuring that command registration happens after the complete workflow initialization. This prevents potential race conditions and ensures that all commands are properly available to users with the correct workflow context.
Technical Details
self.command.register_all(&base_workflow)call out of the conditional logic ininit_state()Why This Change Is Important
Without this fix, commands might be registered with an incomplete workflow configuration, potentially leading to inconsistent command behavior or missing custom commands defined in workflows.