-
Notifications
You must be signed in to change notification settings - Fork 885
feat: add update
functionality on startup and an update command for manual updates
#720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
update
functionality on startup and an update command for manual updates
PR Looks great! Added a few comments and made minor UI changes. |
Moving to draft to reduce noise and improve CI efficiency. Once you are ready just mark it as "ready to review". Feel free to give a shoutout on the #contributors channel on Discord if you want immediate attention. |
I added one more commit to remove some unused code |
Using forge to build forge is next level 😂 💯🔥 |
@iambenkay I think we should not show the spinner. That way the user knows that update happened successfully of if there was a failure. |
So then we will stick to showing stdio? |
I had another idea actually. What if we ask forge to update forge? For eg: When we know that its to check for updates, we can create a prompt on behalf of the user make forge update itself. The pro is that its much simpler for us to implement it and more robust, for eg: sometimes there are failures, which forge can itself fix. The con is that if the user isn't connected to the provider, it won't be able to update automatically (Which I think might be ok). WDYT? Im tusharmath on discord, if you want to converse in RT. |
Alright, I will beep you on Discord with my questions about this approach! |
Co-authored-by: laststylebender <43403528+laststylebender14@users.noreply.github.com>
…line update execution
What's new?
Note
I simulated an older version by passing the
APP_VERSION
environment when running the appFlow when auto_update is set to false
May.1.2025.Screen.Recording.from.Once-Daily.Update.Prompts.mov
Flow when auto_update is set to true
Screen.Recording.2025-05-01.at.11.36.02.AM.mov
/claim #711
closes #711