8000 feat: add `update` functionality on startup and an update command for manual updates by iambenkay · Pull Request #720 · antinomyhq/forge · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add update functionality on startup and an update command for manual updates #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
May 9, 2025

Conversation

iambenkay
Copy link
Contributor
@iambenkay iambenkay commented Apr 30, 2025

What's new?

  • Implemented the check update functionality on startup
  • Adds version info to banner display
  • Allow default update frequency to be overridden by forge.yaml

Note

I simulated an older version by passing the APP_VERSION environment when running the app

APP_VERSION=0.79.0 FORGE_KEY=forge_key cargo run

Flow when auto_update is set to false

May.1.2025.Screen.Recording.from.Once-Daily.Update.Prompts.mov

Flow when auto_update is set to true

Screen.Recording.2025-05-01.at.11.36.02.AM.mov

/claim #711
closes #711

@CLAassistant
Copy link
CLAassistant commented Apr 30, 2025

CLA assistant check
All committers have signed the CLA.

@iambenkay iambenkay changed the title Adds update functionality on startup and an update command for custom updates Adds update functionality on startup and an update command for manual updates Apr 30, 2025
@tusharmath tusharmath changed the title Adds update functionality on startup and an update command for manual updates feat: add update functionality on startup and an update command for manual updates May 2, 2025
@tusharmath
Copy link
Collaborator

PR Looks great! Added a few comments and made minor UI changes.

@tusharmath tusharmath marked this pull request as draft May 2, 2025 08:07
@tusharmath
Copy link
Collaborator

Moving to draft to reduce noise and improve CI efficiency. Once you are ready just mark it as "ready to review". Feel free to give a shoutout on the #contributors channel on Discord if you want immediate attention.

@iambenkay iambenkay marked this pull request as ready for review May 2, 2025 10:55
@iambenkay
Copy link
Contributor Author

I added one more commit to remove some unused code

@iambenkay
Copy link
Contributor Author

Using forge to build forge is next level 😂 💯🔥

@tusharmath
Copy link
Collaborator

@iambenkay I think we should not show the spinner. That way the user knows that update happened successfully of if there was a failure.

@iambenkay
Copy link
Contributor Author

So then we will stick to showing stdio?

@tusharmath
Copy link
Collaborator

I had another idea actually. What if we ask forge to update forge? For eg: When we know that its to check for updates, we can create a prompt on behalf of the user make forge update itself. The pro is that its much simpler for us to implement it and more robust, for eg: sometimes there are failures, which forge can itself fix. The con is that if the user isn't connected to the provider, it won't be able to update automatically (Which I think might be ok). WDYT? Im tusharmath on discord, if you want to converse in RT.

@iambenkay
Copy link
Contributor Author

Alright, I will beep you on Discord with my questions about this approach!

iambenkay and others added 2 commits May 6, 2025 07:58
Co-authored-by: laststylebender <43403528+laststylebender14@users.noreply.github.com>
@iambenkay iambenkay marked this pull request as draft May 6, 2025 13:37
@iambenkay iambenkay marked this pull request as ready for review May 6, 2025 13:40
@tusharmath tusharmath enabled auto-merge (squash) May 9, 2025 12:11
@tusharmath tusharmath merged commit 4ec08f0 into antinomyhq:main May 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Once-Daily Update Prompts
5 participants
0