This repository was archived by the owner on Feb 7, 2024. It is now read-only.
feat(twoslash)!: move to twoslash package for better performance and composablity
#91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shikiji ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=======================================
Coverage 96.96% 96.97%
=======================================
Files 49 49
Lines 4318 4326 +8
Branches 532 533 +1
=======================================
+ Hits 4187 4195 +8
Misses 129 129
Partials 2 2 ☔ View full report in Codecov by Sentry. |
twoslashes for better performance and composablitytwoslash for better performance and composablity
twoslash for better performance and composablitytwoslash package for better performance and composablity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
@typescript/twoslashtotwoslash. This should provide better performance and composablity.This is a breaking change that might affect existing renderers and custom twoslash functions, as Shikiji now would expect the new return format. For high-level usages, it should be imperceptible.
This also allows
vitepress-plugin-twoslashto shiptwoslash-vuefor Vue SFC typechecking. Live example: https://deploy-preview-91--shikiji.netlify.app/packages/vitepress#vue-single-file-component