feat: Support Dynamic Import in Webpack Context #53
Conversation
Webpack will try to bundle modules during compile time and replacing the original `require`, so using `require` directly in the Webpack context to load configs could result in `MODULE_NOT_FOUND` error. Switching to `__non_webpack_require__` to use plain `require` while in the Webpack environment.
|
Thanks for the PR and the detailed description. I am happy to merge the change to the requireFunc. Can you please explain for the need to increase required nodejs version besides EOL? My initial impression is that it is unrelated to this PR and should be omitted. Making a change to required nodejs version is an unnecessary breaking change. Perhaps I am missing some context here. Can you expand on it? Updating dependencies is out of scope for this PR. Please revert that commit. |
|
Remove both dependency and NodeJS changes, just want to make the code up-to-date but indeed they are unnecessary for this PR. |
|
Thanks for updating the PR. I've tested the changes locally by bundling a cli app and it worked for the sync loader. To merge this PR we need to also make it work for the async loader as currently webpack replaces native To fix it please make the following change - const mod = await import(id);
+ const mod = await import(/* webpackIgnore: true */ id);Once updated I am happy to merge this PR and release a new version. |
Supports the async import scenario
|
Thanks for the testing and suggestion, just updated the PR |
|
Published in v3.1.2 Thank you! |
|
@antonk52 any chance you know someone on the tailwindcss team? They're one of the bigger users and they're pinned to 2.1.0, and it's causing all kinds of havoc with next.js+tailwind projects and conflicting lilconfig versions in the bundle. tailwindlabs/tailwindcss#14029 |
|
Unfortunately, I don't know anyone directly. I can only suggest getting the PR rebased to be in a merge-able state and the latest lilconfig version. Then (maybe?) tag someone with merge permissions in said repository. While tagging people directly is a bad practice due to that issue will address a security vulnerability and support for large platforms such as windows sound important enough for me to ping someone directly. |
Credit: Thanks @jeremiegirault for proposing the changes in sindresorhus/import-fresh#21
Description
Webpack will try to bundle modules during compile time and replace the original
require, so usingrequiredirectly in the Webpack context to load configs could result inMODULE_NOT_FOUNDerror. Switching to__non_webpack_require__to use plainrequirewhile in the Webpack environment.About
__non_webpack_require__:Try to solve issues like:
Making these changes will eventually make it possible to replace
cosmiconfigwithlilconfiginnext-loggerTest
npm run test