-
-
Notifications
You must be signed in to change notification settings - Fork 52.8k
feat: ConfigProvider support Badge.Ribbon #52303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👁 Visual Regression Report for PR #52303 Failed ❌
Important There are 6 diffs found in this PR: 🔄
|
WalkthroughThis pull request introduces a new feature to the Changes
|
More templates
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #52303 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 760 760
Lines 13673 13673
Branches 3570 3570
=========================================
Hits 13673 13673 ☔ View full report in Codecov by Sentry. |
cn: { | ||
root: '根节点', | ||
body: '主体节点', | ||
text: '文本节点', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看起来也是 content?这里不一定放 text 的。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
root: '根节点', | ||
body: '主体节点', | ||
text: '文本节点', | ||
corner: '角标节点', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个先不加吧,感觉是很容易重构坏掉的 dom 的。先不要承诺给人用。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bundle ReportChanges will increase total bundle size by 5.86kB (0.17%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
components/badge/Ribbon.tsx
Outdated
@@ -46,6 +52,9 @@ const Ribbon: React.FC<RibbonProps> = (props) => { | |||
[`${prefixCls}-color-${color}`]: colorInPreset, | |||
}, | |||
className, | |||
ribbon?.className, | |||
ribbon?.classNames?.body, | |||
ribbonClassNames?.body, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个应该和 Badge 标准版一样叫做 indicator
,下面 content
没问题
|
||
const locales = { | ||
cn: { | ||
root: '根节点', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个中文要不统一一下 我看有元素也有节点
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok 我改一下~
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
close #48089
close #48169
💡 Background and Solution
📝 Change Log
classNames
andstyles
andclassName
andstyle
.classNames
和styles
和className
和style