8000 FIX: multi-version documentation layout by jorgepiloto · Pull Request #163 · ansys/actions · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

FIX: multi-version documentation layout #163

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Feb 21, 2023
Merged

FIX: multi-version documentation layout #163

merged 33 commits into from
Feb 21, 2023

Conversation

jorgepiloto
Copy link
Member
@jorgepiloto jorgepiloto commented Feb 6, 2023 •
edited
Loading

Continuation of #161 to apply the changes proposed in #155. Fixes #154.

Testing this logic in https://github.com/pyansys/test-multiversion.

Action Current repository External repository
Development deploy Verified Verified
Stable deploy Verified Verified

@github-actions github-actions bot added the bug Defects or glitches reported by users or developers label Feb 6, 2023

@jorgepiloto jorgepiloto force-pushed the fix/multi-version branch 9 times, most recently from 56ef459 to f2490c4 Compare February 7, 2023 16:43
@jorgepiloto
Copy link
Member Author

Just came up with the following algorithm. It simplifies a lot the Python script logic and ensures projects is more maintainable:

  1. Evaluate the tag version to identify MAJOR and MINOR.
  2. Download doc stable artifacts in version/MAJOR.MINOR/. No issues if overriding (PATCH release).
  3. List and order from high to low all version/X.Y/ dirs.
  4. Select up to render-last input.
  5. The major one is the stable. Copy-paste its content to the version/stable.
  6. Generate a fresh JSON file for the version.
  7. Update index.html according to latest stable.
  8. Update announcements.html according to latest stable.
  9. Deploy whole content.

@jorgepiloto jorgepiloto marked this pull request as ready for review February 8, 2023 13:21
@github-actions github-actions bot added the maintenance Generic maintenance related label Feb 8, 2023
@jorgepiloto jorgepiloto force-pushed the fix/multi-version branch 12 times, most recently from 0819313 to 1969c44 Compare February 14, 2023 09:57
RobPasMue
RobPasMue approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member
@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These actions are awesome. Thanks @jorgepiloto!

@jorgepiloto jorgepiloto mentioned this pull request Feb 21, 2023
Closed
@jorgepiloto jorgepiloto merged commit 3945cc3 into main Feb 21, 2023
@jorgepiloto jorgepiloto deleted the fix/multi-version branch February 21, 2023 09:43
@jorgepiloto jorgepiloto mentioned this pull request Feb 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@Revathyvenugopal162 Revathyvenugopal162 Revathyvenugopal162 approved these changes

@germa89 germa89 Awaiting requested review from germa89

@MaxJPRey MaxJPRey Awaiting requested review from MaxJPRey

Assignees
No one assigned
Labels
bug Defects or glitches reported by users or developers maintenance Generic maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation crawlers going crazy with release folder approach
4 participants
@jorgepiloto @RobPasMue @MaxJPRey @Revathyvenugopal162
0