Fix 500 error when creating a job schedule #5084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 500 error occurs when a non-admin user attempts to add an invalid credential during schedule creation - This change checks that the user can add the object to serializer.validated_data, instead of serializer.initial_data - The invalid credential field is purged in .validated_data, so the request passes through cleanly - Fix for awx issue ansible#4147
|
Build succeeded.
|
ryanpetrello
approved these changes
Oct 24, 2019
|
Build failed (gate pipeline). For information on how to proceed, see
|
|
regate |
|
Build failed (gate pipeline). For information on how to proceed, see
|
|
regate |
|
Build failed (gate pipeline). For information on how to proceed, see
|
|
regate |
|
Build succeeded (gate pipeline).
|
AlanCoding
pushed a commit
to AlanCoding/awx
that referenced
this pull request
Jun 23, 2021
Remove test button from logging settings screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for issue #4147
A 500 error occurs when a non-admin user attempts to add an invalid credential during schedule creation.
This one-line change checks that the user can add the object to
serializer.validated_data, instead ofserializer.initial_data.The invalid credential field is purged in
serializer.validated_data, so the request passes through cleanly.SUMMARY
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION