8000 Remove pause logic form junos_netconf tests (#57966) by pabelanger · Pull Request #58071 · ansible/ansible · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove pause logic form junos_netconf tests (#57966) #58071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2019
Merged

Remove pause logic form junos_netconf tests (#57966) #58071

merged 1 commit into from
Jun 19, 2019

Conversation

pabelanger
Copy link
Contributor
SUMMARY

Backport #57966 to deal with junos timeouts

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

junos_netconf

@pabelanger
Remove pause logic form junos_netconf tests (ansible#57966)
3ef0880 
We can switch to wait_for / meta, as using pause can lead to race
conditions on slower / faster hardware.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
(cherry picked from commit 8dc51df)
@ansibot
Copy link
Contributor
ansibot commented Jun 19, 2019

cc @Qalthos @ganeshrn @privateip
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jun 19, 2019
@pabelanger
Copy link
Contributor Author

@abadger Once we merge this PR to stable-2.8, we'll be in good shape to start reporting junos results on stable-2.8!

@abadger abadger merged commit 7bd503c into ansible:stable-2.8 Jun 19, 2019
@abadger
Copy link
Contributor
abadger commented Jun 19, 2019

Merged for the 2.8.2 release. @pabelanger Yay!

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jun 21, 2019
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pabelanger @ansibot @abadger @sivel
0