8000 Pull request for temp/iosxr-back by pabelanger · Pull Request #58075 · ansible/ansible · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Pull request for temp/iosxr-back #58075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 19, 2019
Merged

Pull request for temp/iosxr-back #58075

merged 2 commits into from
Jun 19, 2019

Conversation

pabelanger
Copy link
Contributor
@pabelanger pabelanger commented Jun 19, 2019 •
edited
Loading
SUMMARY

Backport of #57919 to make iosxr_config python3 compatible

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

iosxr_config

Depends-On: #58073

@pabelanger pabelanger closed this Jun 19, 2019
@pabelanger pabelanger reopened this Jun 19, 2019
@pabelanger
Fix python3 encoding with iosxr_config (ansible#57919)
a7529cb 
Python3 requires bytes when writing files.

(cherry picked from commit d40c44b)
Depends-On ansible#58073
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger
Add changelog fragment
f6cc263 
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger
Copy link
Contributor Author

Pull-request updated, HEAD is now f6cc263

@ansibot
Copy link
Contributor
ansibot commented Jun 19, 2019

cc @gdpak @rcarrillocruz
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community iosxr Cisco IOSXR community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category python3 support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jun 19, 2019
@pabelanger pabelanger mentioned this pull request Jun 19, 2019
Merged
@pabelanger
Copy link
Contributor Author

Along with #58073 iosxr tests are passing on stable-2.8!

@abadger abadger merged commit 2dac2d1 into ansible:stable-2.8 Jun 19, 2019
@abadger
Copy link
Contributor
abadger commented Jun 19, 2019

Merged for the 2.8.2 release.

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jun 21, 2019
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community iosxr Cisco IOSXR community module This issue/PR relates to a module. networking Network category python3 support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pabelanger @ansibot @abadger @sivel
0