-
Notifications
You must be signed in to change notification settings - Fork 24k
Ignore the google-auth library warning for user credentials #57964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “ 8000 Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore the google-auth library warning for user credentials #57964
Conversation
I know we removed this warning earlier, but I'm really hesitant to add this warning back in. Even though 'application user credentials' are a valid option for Ansible, service accounts are the recommended authentication strategy. I don't want this warning to be blocked for all users because many users should heed this message. Truthfully, I don't know how I missed this warning the first time it was merged in. I probably wouldn't have let it get merged the first time around. |
Could I get some context on the fix? (I didn't fully understand the comment about non-interactive Python) What use-case are you using currently? |
I don't see a comment, about non-interactive, but I got it in my email. I guess the idea is if you are running ansible from an interactive shell (like e.g. devs do on their workstations) you shouldn't get a warning, but if you are running ansible from a non-interactive session like CI tools do, you should get a warning. |
Yeah, I also got it in my email but not on the thread. Do users use Ansible through an interactive shell? I've personally never heard of anyone using Ansible in that way (doesn't mean they don't!). Is this error message breaking any workflows for you? |
I use it constantly on my workstation, you have to do development like that
at least, or to run it against some test/dev environments. It doesn't break
workfkows, it's just bad experience for the devs when running Ansible.
Especially since there are use cases when it's better to use your own
account, instead of a service account.
It's currently not that big of a deal because now Ansible prints one one
warning, but before when it queried each zone separately it printed a whole
screen of warnings before everything which was awful.
…On Mon, Aug 12, 2019, 19:39 Alex Stephen ***@***.***> wrote:
Yeah, I also got it in my email but not on the thread.
Do users use Ansible through an interactive shell? I've personally never
heard of anyone using Ansible in that way (doesn't mean they don't!).
Is this error message breaking any workflows for you?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#57964?email_source=notifications&email_token=AAO34LOP6V7ENLSOKGH4H6DQEGN5RA5CNFSM4HYZMFS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4DIRMY#issuecomment-520521907>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAO34LOQZE3ZAR64E3YWLULQEGN5RANCNFSM4HYZMFSQ>
.
|
Sorry to hear about that! I believe the errors are sent to stderr, so you might be able to turn them off a different way. For the moment, I'm going to close this out, because I believe this is working as intended. close_me |
SUMMARY
In the PR #57730, I guess by a mistake, filtering google-auth lib user credentials warnings was removed, so I'm returning it back. More details about the reasoning to remove this warning can be found here: googleapis/google-auth-library-python#271
ISSUE TYPE
COMPONENT NAME
gcp_compute