8000 Ignore the google-auth library warning for user credentials by kustodian · Pull Request #57964 · ansible/ansible · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ignore the google-auth library warning for user credentials #57964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “ 8000 Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kustodian
Copy link
Contributor
SUMMARY

In the PR #57730, I guess by a mistake, filtering google-auth lib user credentials warnings was removed, so I'm returning it back. More details about the reasoning to remove this warning can be found here: googleapis/google-auth-library-python#271

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

gcp_compute

@ansibot
Copy link
Contributor
ansibot commented Jun 17, 2019

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Jun 17, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 25, 2019
@rambleraptor
Copy link
Contributor

I know we removed this warning earlier, but I'm really hesitant to add this warning back in.

Even though 'application user credentials' are a valid option for Ansible, service accounts are the recommended authentication strategy. I don't want this warning to be blocked for all users because many users should heed this message.

Truthfully, I don't know how I missed this warning the first time it was merged in. I probably wouldn't have let it get merged the first time around.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Aug 8, 2019
@rambleraptor
Copy link
Contributor

Could I get some context on the fix? (I didn't fully understand the comment about non-interactive Python) What use-case are you using currently?

@kustodian
Copy link
Contributor Author

I don't see a comment, about non-interactive, but I got it in my email. I guess the idea is if you are running ansible from an interactive shell (like e.g. devs do on their workstations) you shouldn't get a warning, but if you are running ansible from a non-interactive session like CI tools do, you should get a warning.

@rambleraptor
Copy link
Contributor

Yeah, I also got it in my email but not on the thread.

Do users use Ansible through an interactive shell? I've personally never heard of anyone using Ansible in that way (doesn't mean they don't!).

Is this error message breaking any workflows for you?

@kustodian
Copy link
Contributor Author
kustodian commented Aug 12, 2019 via email

@rambleraptor
Copy link
Contributor

Sorry to hear about that! I believe the errors are sent to stderr, so you might be able to turn them off a different way.

For the moment, I'm going to close this out, because I believe this is working as intended.

close_me

@ansibot ansibot closed this Aug 22, 2019
@ansible ansible locked and limited conversation to collaborators Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0