8000 Documentation error by anis016 · Pull Request #57924 · ansible/ansible · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Documentation error #57924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally sen 8000 d you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2019
Merged

Documentation error #57924

merged 2 commits into from
Jun 18, 2019

Conversation

anis016
Copy link
Contributor
@anis016 anis016 commented Jun 16, 2019

Corrected Test if a list contains a value section. Allowed filters are 'select/reject' and 'selectattr/rejectattr'.

+label: docsite_pr

Fixes: #56644

  • Docs Pull Request

@anis016
Documentation error
aced2dd 
Corrected Test if a list contains a value section. Allowed filters are 'select/reject' and 'selectattr/rejectattr'.

+label: docsite_pr
@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Jun 16, 2019
@anis016
Copy link
Contributor Author
anis016 commented Jun 17, 2019

cc @acozine

@acozine
Copy link
Contributor
acozine commented Jun 17, 2019

Thanks @anis016 for picking up this issue!

acozine
acozine reviewed Jun 17, 2019
View reviewed changes
Copy link
Contributor
@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great - here's a way to make it even better.

@anis016 @acozine
Update changelogs/fragments/contains-test.yaml
8252da9 
Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
@acozine
Copy link
Contributor
acozine commented Jun 18, 2019

Thanks @anis016!

@acozine acozine merged commit 9da6fc1 into ansible:stable-2.8 Jun 18, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jun 18, 2019
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acozine acozine acozine left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anis016 @acozine @sivel @dagwieers @ansibot
0