8000 Fix junos integration zuul CI failures by ganeshrn · Pull Request #57755 · ansible/ansible · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix junos integration zuul CI failures #57755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Fix junos integration zuul CI failures #57755

wants to merge 6 commits into from

Conversation

ganeshrn
Copy link
Member
@ganeshrn ganeshrn commented Jun 12, 2019 •
edited
Loading
SUMMARY

  • Convert the ElementTree object to string
    before dumping the configuration in file.

  • Fix netconf plugin to return data_xml object
    if present for the device handler object or else return raw xml.

  • Add check to run lldp integration test cases only if lldp is
    supported on the target host

Merged PR to devel
#57309
#57578
#56452
#56138

(cherry picked from commit 9c5745a)
(cherry picked from commit 0957835)
(cherry picked from commit 2ca324b)
(cherry picked from commit 647ed20)

ISSUE TYPE
  • Bugfix Pull Request
  • Test Pull Request
COMPONENT NAME

plugins/netconf/init.py
netconf_config
netconf_get

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor
ansibot commented Jun 12, 2019

cc @NilashishC @Qalthos @gdpak @justjais @lpenz @privateip @rcarrillocruz @trishnaguha @userlerueda
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jun 12, 2019
@ganeshrn ganeshrn force-pushed the backport/stable_2.7/57309 branch from 9dde176 to 6c37fbd Compare June 12, 2019 14:26
@ansibot
Copy link
Contributor
ansibot commented Jun 12, 2019

cc @wisotzky
click here for bot help

@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Jun 12, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jun 12, 2019
@pabelanger
Copy link
Contributor

recheck

@ganeshrn ganeshrn force-pushed the backport/stable_2.7/57309 branch 2 times, most recently from 60ff1cd to d028949 Compare June 17, 2019 05:10
@ganeshrn
Fix junos integration zuul CI failures
fffe63f 
*  Convert the ElementTree object to string
   before dumping the configuration in file.

* Fix netconf plugin to return data_xml object
  if present for the device handler object or else return raw xml.

* Add check to run lldp integration test cases only if lldp is
  supported on the target host

Merged PR to devel
ansible#57309
ansible#57578
ansible#56452

(cherry picked from commit 9c5745a)
(cherry picked from commit 0957835)
(cherry picked from commit 2ca324b)
@ganeshrn ganeshrn force-pushed the backport/stable_2.7/57309 branch from d028949 to fffe63f Compare June 18, 2019 15:14
pabelanger
pabelanger suggested changes Jun 18, 2019
View reviewed changes
Copy link
Contributor
@pabelanger pabelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we are seeing a failure in netconf_config:

https://logs.zuul.ansible.com/55/57755/fffe63f82ed015983d45553d435d7347b2be4388/third-party-check-silent/ansible-test-network-integration-junos-python27/d964840/controller/ara-report/result/d66b1496-2033-4f1b-ad07-eaeefd5957c7/

We should also fix that here, to minimize the number of backports.

@wjohnston888 @ganeshrn
Fixes Netconf_config single parameter bug (ansible#56138)
6d2c2ea 
* Fixes Netconf_config single parameter bug
Fixes 56022

fixed get_config to not require multiple parameters to just run a backup

* Add Integration test for netconf_config
Associated with ansible#56022

tests backup through netconf only using one parameter.

* Added debug to the begin and end of file

* Fix formatting of save config.  ansible#56022

* removed blank line at end: ansible#56022

(cherry picked from commit 647ed20)
@ganeshrn ganeshrn force-pushed the backport/stable_2.7/57309 branch from 5bd7515 to 6d2c2ea Compare June 19, 2019 06:21
@ganeshrn
Copy link
Member Author

@pabelanger Backported PR #56138 and updated the changelog

@pabelanger
Copy link
Contributor

recheck

@pabelanger
Copy link
Contributor

@ganeshrn please include #57966 and #57073 to help improve test stability

@pabelanger pabelanger mentioned this pull request Jun 20, 2019
Closed
pabelanger pushed a commit to pabelanger/ansible that referenced this pull request Jun 20, 2019
@ganeshrn @pabelanger
More iosxr integration zuul CI test fixes (ansible#57909)
7f420f5 
* Ignore `<rpc-reply>` node from candidate and
  running configuration in xml diff

(cherry picked from commit 4a3e14f)
Depends-On: ansible#57755
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger
Copy link
Contributor

@ganeshrn I also need you to backport #57882 as you have included #56138 which had a bug.

pabelanger and others added 3 commits June 21, 2019 08:49
@pabelanger @ganeshrn
Remove pause logic form junos_netconf tests (ansible#57966)
3270f43 
We can switch to wait_for / meta, as using pause can lead to race
conditions on slower / faster hardware.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
(cherry picked from commit 8dc51df)
@pabelanger @ganeshrn
Use wait_for in prepare_junos_tests.yaml (ansible#57073)
fde1e37 
This should reduce the amount of time we are waiting for netconf to come
online.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
(cherry picked from commit 7f53663)
@ganeshrn
Fix iosxr netconf integration test (ansible#57882)
ca23eb9 
* Modify testcase to work with Zuul CI enviornment

(cherry picked from commit 0d2ffdd)
@ganeshrn ganeshrn force-pushed the backport/stable_2.7/57309 branch from 4a61183 to ca23eb9 Compare June 21, 2019 03:24
pabelanger pushed a commit to pabelanger/ansible that referenced this pull request Jun 21, 2019
@ganeshrn @pabelanger
More iosxr integration zuul CI test fixes (ansible#57909)
a428c93 
* Ignore `<rpc-reply>` node from candidate and
  running configuration in xml diff

(cherry picked from commit 4a3e14f)
Depends-On: ansible#57755
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger pushed a commit to pabelanger/ansible that referenced this pull request Jun 24, 2019
@ganeshrn @pabelanger
More iosxr integration zuul CI test fixes (ansible#57909)
fa9cb4e 
* Ignore `<rpc-reply>` node from candidate and
  running configuration in xml diff

(cherry picked from commit 4a3e14f)
Depends-On: ansible#57755
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@abadger
Copy link
Contributor
abadger commented Jun 24, 2019

The decision from the networking team leadership is that none of these bugs qualify as critical so we'll have to continue testing stable-2.7 releases manually rather than enabling zuul for 2.7.x

@abadger abadger closed this Jun 24, 2019
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pabelanger pabelanger pabelanger requested changes

@danielmellado danielmellado danielmellado approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ganeshrn @ansibot @pabelanger @abadger @danielmellado @wjohnston888
0