8000 nxos_ospf_vrf: Add 'bfd' support by chrisvanheuveln · Pull Request #56748 · ansible/ansible · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

nxos_ospf_vrf: Add 'bfd' support #56748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

nxos_ospf_vrf: Add 'bfd' support #56748

wants to merge 0 commits into from

Conversation

chrisvanheuveln
Copy link
Contributor
SUMMARY

Add support for bfd state in nxos_ospf_vrf

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

nxos_ospf_vrf

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor
ansibot commented May 21, 2019

cc @GGabriele @NilashishC @Qalthos @ganeshrn @gdpak @justjais @mikewiebe @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels May 21, 2019
@trishnaguha trishnaguha self-assigned this May 22, 2019
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label May 22, 2019
This was referenced May 24, 2019
Closed
Closed
Closed
@mikewiebe
Copy link
Contributor

LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels May 29, 2019
Qalthos
Qalthos suggested changes Jun 5, 2019
View reviewed changes
lib/ansible/modules/network/nxos/nxos_ospf_vrf.py Outdated
- Enables BFD on all OSPF interfaces.
- "Dependency: 'feature bfd'"
version_added: "2.9"
type: bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've listed a default in the argspec, but not in the documentation

Suggested change
type: bool
type: bool
default: false

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed shipit This PR is ready to be merged by Core labels Jun 5, 2019
@chrisvanheuveln chrisvanheuveln mentioned this pull request Jun 5, 2019
Merged
@chrisvanheuveln
Copy link
Contributor Author

I did a rebase and push --force but... something happened and it wiped out my earlier commits, which apparently then caused it to auto-close this PR. I wasn't sure if the branch was fixable so I just created a new branch and patched the commits to it. The replacement PR is #57425

@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos requested changes

Assignees

@trishnaguha trishnaguha

Labels
affects_2.9 This issue/PR affects Ansible v2.9 cisco Cisco technologies feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category nxos Cisco NXOS community stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrisvanheuveln @ansibot @mikewiebe @Qalthos @trishnaguha
0