8000 added openstack module for retrieving stack facts by xinau · Pull Request #47748 · ansible/ansible · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

added openstack module for retrieving stack facts #47748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

added openstack module for retrieving stack facts #47748

wants to merge 3 commits into from

Conversation

xinau
Copy link
@xinau xinau commented Oct 29, 2018 •
edited
Loading
SUMMARY

Added a new module for retrieving facts for a given openstack stack by name.
I created this module, due to the fact that I want to create a stack in one playbook and use these stack facts in another playbook. At a point later in time. I didn't extend the existing os_stack module cause it seems to be a convention for the openstack modules (os_image_facts, os_server_facts...)

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
ANSIBLE VERSION
devel

Closes: #33834

@ansibot
Copy link
Contributor
ansibot commented Oct 29, 2018

Hi @xinau, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

@SamYaple @agireud @albertomurillo @bennojoy @cloudnull @dagnello @dguerri @evrardjp @flwang @ioggstream @juliakreger @Kong @lingxiankong @mgale @mnaser @odyssey4me @omgjlk @ruizink @Shrews

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot
Copy link
Contributor
ansibot commented Oct 29, 2018

cc @cloudnull @dagnello @emonty @evrardjp @juliakreger @mnaser @odyssey4me @rcarrillocruz @Shrews
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. openstack support:community This issue/PR relates to code supported by the Ansible community. labels Oct 29, 2018
@opendev-zuul
Copy link
opendev-zuul bot commented Oct 29, 2018

Build succeeded (third-party-check pipeline).

@xinau xinau force-pushed the feature-os_stack_facts-module branch from 75480ef to fb68307 Compare October 29, 2018 19:24
@opendev-zuul
Copy link
opendev-zuul bot commented Oct 30, 2018

Build succeeded (third-party-check pipeline).

@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Nov 1, 2018
@mnaser
Copy link
Contributor
mnaser commented Nov 1, 2018

Seems straight forward

@mnaser
Copy link
Contributor
mnaser commented Nov 1, 2018

shipit

gtema
gtema approved these changes Nov 5, 2018
View reviewed changes
Copy link
Contributor
@gtema gtema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 13, 2018
@czunker czunker mentioned this pull request Dec 24, 2018
Closed
@brtkwr
Copy link
brtkwr commented Mar 6, 2019

For the record, we build a similar module to solve this problem a while back (https://github.com/stackhpc/ansible-role-os-container-infra/blob/master/library/os_stack_facts.py) but I like this approach as it doesn't depend on the python-heatclient!

@priteau priteau mentioned this pull request Mar 14, 2019
Merged
brtkwr pushed a commit to stackhpc/ansible-role-os-container-infra that referenced this pull request Mar 23, 2019
Update existing os_stack_facts.py with upstream version (which only uses
56051d3 
openstacksdk) until the PR is merged.

PR: ansible/ansible#47748
gtema
gtema suggested changes Apr 4, 2019
View reviewed changes
Copy link
Contributor
@gtema gtema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xinau, if you would fix this small thing the PR will be accepted

@ansibot
Copy link
Contributor
ansibot commented Apr 4, 2019

cc @gtema
click here for bot help

@gtema
Copy link
Contributor
gtema commented Apr 5, 2019

shipit

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 13, 2019
@gtema
Copy link
Contributor
gtema commented Jun 18, 2019

recheck

@opendev-zuul
Copy link
opendev-zuul bot commented Jun 18, 2019

Build succeeded (third-party-check pipeline).

@gtema
Copy link
Contributor
gtema commented Jun 18, 2019

shipit

cloudnull
cloudnull approved these changes Jun 20, 2019
View reviewed changes
Copy link
Contributor
@cloudnull cloudnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 20, 2019
@ansibot
Copy link
Contributor
ansibot commented Jun 20, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/cloud/openstack/os_stack_facts.py:0:0: E307 version_added should be '2.9'. Currently '2.8'
lib/ansible/modules/cloud/openstack/os_stack_facts.py:0:0: E338 Argument 'availability_zone' in argument_spec uses default type ('str') but documentation doesn't define type
lib/ansible/modules/cloud/openstack/os_stack_facts.py:0:0: E338 Argument 'name' in argument_spec uses default type ('str') but documentation doesn't define type

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed shipit This PR is ready to be merged by Core labels Jun 20, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 28, 2019
@ruizink ruizink mentioned this pull request Oct 8, 2019
Closed
@sshnaidm
Copy link
Contributor

Thanks for submitting patch for Openstack Ansible modules!
We moved Openstack Ansible modules to Openstack repositories.
Next patches should be submitted not with Ansible Github but with
Openstack Gerrit: https://review.opendev.org/#/q/project:openstack/ansible-collections-openstack
Please submit your code there from now.
Thanks for your contribution and sorry for inconvienience.

@ansibot ansibot added collection Related to Ansible Collections work collection:openstack.cloud needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed collection:openstack.cloud needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md support:community This issue/PR relates to code supported by the Ansible community. labels Jul 23, 2020
@Akasurde
Copy link
Member

@xinau Thanks for the contribution. Closing as per above.

@Akasurde Akasurde closed this Aug 19, 2020
@ansible ansible locked as resolved and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brtkwr brtkwr brtkwr approved these changes

@cloudnull cloudnull cloudnull approved these changes

@gtema gtema gtema approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 ci_verified Changes made in this PR are causing tests to fail. cloud collection Related to Ansible Collections work has_issue module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. openstack stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add os_stack_facts module for OpenStack
9 participants
@xinau @ansibot @mnaser @brtkwr @gtema @sshnaidm @Akasurde @cloudnull @jborean93
0