8000 Add os_nova_service by mnaser · Pull Request #45701 · ansible/ansible · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add os_nova_service #45701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add os_nova_service #45701

wants to merge 1 commit into from

Conversation

mnaser
Copy link
Contributor
@mnaser mnaser commented Sep 16, 2018
SUMMARY

This module is useful for maintenance tasks such as disabling
a compute node in order to perform maintenance operations on it.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

os_nova_service

@ansibot
Copy link
Contributor
ansibot commented Sep 16, 2018

cc @dagnello @emonty @juliakreger @omgjlk @rcarrillocruz @Shrews @Thingee
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. openstack support:community This issue/PR relates to code supported by the Ansible community. labels Sep 16, 2018
@ansibot
Copy link
Contributor
ansibot commented Sep 16, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/cloud/openstack/os_nova_service.py:0:0: E307 version_added should be 2.8. Currently 2.0
lib/ansible/modules/cloud/openstack/os_nova_service.py:0:0: E322 "availability_zone" is listed in the argument_spec, but not documented in the module

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. ci_verified Changes made in this PR are causing tests to fail. labels Sep 16, 2018
@mnaser
Add os_nova_service
a42576b 
This module is useful for maintenance tasks such as disabling
a compute node in order to perform maintenance operations on it.
@ansibot
Copy link
Contributor
ansibot commented Sep 16, 2018

@SamYaple @agireud @albertomurillo @bennojoy @dagnello @flwang @ioggstream @juliakreger @Kong @lingxiankong @mgale @omgjlk @ruizink @Shrews @Thingee

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 16, 2018
@opendev-zuul
Copy link
opendev-zuul bot commented Sep 16, 2018

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@mnaser
Copy link
Contributor Author
mnaser commented Sep 16, 2018

The third party check error is unrelated.

@mnaser
Copy link
Contributor Author
mnaser commented Sep 17, 2018

recheck

@opendev-zuul
Copy link
opendev-zuul bot commented Sep 17, 2018

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@mnaser
Copy link
Contributor Author
mnaser commented Sep 18, 2018

recheck

@ryansb ryansb removed the needs_triage Needs a first human triage before being processed. label Sep 18, 2018
@opendev-zuul
Copy link
opendev-zuul bot commented Sep 18, 2018

Build succeeded (third-party-check pipeline).

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 26, 2018
@ansibot
Copy link
Contributor
ansibot commented Nov 2, 2018

cc @cloudnull @evrardjp @odyssey4me
click here for bot help

@ansibot
Copy link
Contributor
ansibot commented Apr 6, 2019

cc @gtema
click here for bot help

@sshnaidm
Copy link
Contributor

Thanks for submitting patch for Openstack Ansible modules!
We moved Openstack Ansible modules to Openstack repositories.
Next patches should be submitted not with Ansible Github but with
Openstack Gerrit: https://review.opendev.org/#/q/project:openstack/ansible-collections-openstack
Please submit your code there from now.
Thanks for your contribution and sorry for inconvienience.

@ansibot ansibot added the needs_repo This PR no longer has an associated branch as it was removed by the submitter. label Jan 20, 2020
@ansibot ansibot added collection Related to Ansible Collections work collection:openstack.cloud needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed collection:openstack.cloud community_review In order to be merged, this PR must follow the community review workflow. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md support:community This issue/PR relates to code supported by the Ansible community. labels Jul 15, 2020
@Akasurde
Copy link
Member

@mnaser Thanks for the contribution. Closing as per above.

@Akasurde Akasurde closed this Aug 19, 2020
@ansible ansible locked as resolved and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cloud collection Related to Ansible Collections work core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_repo This PR no longer has an associated branch as it was removed by the submitter. new_module This PR includes a new module. new_plugin This PR includes a new plugin. openstack stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mnaser @ansibot @sshnaidm @Akasurde @ryansb
0