8000 freebsdport module for managing FreeBSD ports by basarevych · Pull Request #32727 · ansible/ansible · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

freebsdport module for managing FreeBSD ports #32727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account rela 8000 ted emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

freebsdport module for managing FreeBSD ports #32727

wants to merge 6 commits into from

Conversation

basarevych
Copy link
SUMMARY

Ansible module that configures, installs, updates and deinstalls FreeBSD ports in canonical way.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

freebsdport

ANSIBLE VERSION
ansible 2.4.1.0
  config file = None
  configured module search path = [u'/home/ross/.ansible/plugins/modules', u'/usr/local/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.14 (default, Oct 19 2017, 01:17:20) [GCC 4.2.1 Compatible FreeBSD Clang 3.8.0 (tags/RELEASE_380/final 262564)]
ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Nov 9, 2017
@ansibot
Copy link
Contributor
ansibot commented Nov 9, 2017

The test ansible-test sanity --test boilerplate [?] failed with the following error:

Command "test/sanity/code-smell/boilerplate.sh" returned exit status 2.
>>> Standard Output
== Missing __metaclass__ = type ==
./lib/ansible/modules/packaging/os/freebsdport.py

== Missing from __future__ import (absolute_import, division, print_function) ==
./lib/ansible/modules/packaging/os/freebsdport.py

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/modules/packaging/os/freebsdport.py:194:48: W291 trailing whitespace
lib/ansible/modules/packaging/os/freebsdport.py:195:124: W291 trailing whitespace
lib/ansible/modules/packaging/os/freebsdport.py:196:141: W291 trailing whitespace
lib/ansible/modules/packaging/os/freebsdport.py:295:12: E714 test for object identity should be 'is not'
lib/ansible/modules/packaging/os/freebsdport.py:304:12: E714 test for object identity should be 'is not'
lib/ansible/modules/packaging/os/freebsdport.py:313:12: E714 test for object identity should be 'is not'
lib/ansible/modules/packaging/os/freebsdport.py:344:24: E714 test for object identity should be 'is not'
lib/ansible/modules/packaging/os/freebsdport.py:347:24: E714 test for object identity should be 'is not'
lib/ansible/modules/packaging/os/freebsdport.py:350:24: E714 test for object identity should be 'is not'
lib/ansible/modules/packaging/os/freebsdport.py:378:16: E714 test for object identity should be 'is not'
lib/ansible/modules/packaging/os/freebsdport.py:424:16: E714 test for object identity should be 'is not'
lib/ansible/modules/packaging/os/freebsdport.py:435:12: E713 test for membership should be 'not in'
lib/ansible/modules/packaging/os/freebsdport.py:438:12: E714 test for object identity should be 'is not'
lib/ansible/modules/packaging/os/freebsdport.py:449:28: E714 test for object identity should be 'is not'
lib/ansible/modules/packaging/os/freebsdport.py:479:26: E201 whitespace after '['
lib/ansible/modules/packaging/os/freebsdport.py:479:31: E202 whitespace before ']'
lib/ansible/modules/packaging/os/freebsdport.py:489:12: E714 test for object identity should be 'is not'
lib/ansible/modules/packaging/os/freebsdport.py:513:24: E713 test for membership should be 'not in'
lib/ansible/modules/packaging/os/freebsdport.py:564:12: E713 test for membership should be 'not in'
lib/ansible/modules/packaging/os/freebsdport.py:584:16: E713 test for membership should be 'not in'
lib/ansible/modules/packaging/os/freebsdport.py:603:16: E713 test for membership should be 'not in'
lib/ansible/modules/packaging/os/freebsdport.py:620:21: W503 line break before binary operator
lib/ansible/modules/packaging/os/freebsdport.py:621:21: W503 line break before binary operator
lib/ansible/modules/packaging/os/freebsdport.py:632:28: E714 test for object identity should be 'is not'
lib/ansible/modules/packaging/os/freebsdport.py:664:16: E201 whitespace after '['
lib/ansible/modules/packaging/os/freebsdport.py:664:38: E202 whitespace before ']'
lib/ansible/modules/packaging/os/freebsdport.py:673:16: E201 whitespace after '['
lib/ansible/modules/packaging/os/freebsdport.py:673:75: E202 whitespace before ']'
lib/ansible/modules/packaging/os/freebsdport.py:678:16: E201 whitespace after '['
lib/ansible/modules/packaging/os/freebsdport.py:678:77: E202 whitespace before ']'
lib/ansible/modules/packaging/os/freebsdport.py:687:16: E713 test for membership should be 'not in'
lib/ansible/modules/packaging/os/freebsdport.py:702:1: W293 blank line contains whitespace
lib/ansible/modules/packaging/os/freebsdport.py:819:16: E201 whitespace after '['
lib/ansible/modules/packaging/os/freebsdport.py:819:49: E202 whitespace before ']'
lib/ansible/modules/packaging/os/freebsdport.py:846:16: E201 whitespace after '['
lib/ansible/modules/packaging/os/freebsdport.py:846:43: E202 whitespace before ']'
lib/ansible/modules/packaging/os/freebsdport.py:854:16: E201 whitespace after '['
lib/ansible/modules/packaging/os/freebsdport.py:854:39: E202 whitespace before ']'
lib/ansible/modules/packaging/os/freebsdport.py:862:12: E713 test for membership should be 'not in'
lib/ansible/modules/packaging/os/freebsdport.py:866:16: E201 whitespace after '['
lib/ansible/modules/packaging/os/freebsdport.py:866:43: E202 whitespace before ']'
lib/ansible/modules/packaging/os/freebsdport.py:872:12: E714 test for object identity should be 'is not'
lib/ansible/modules/packaging/os/freebsdport.py:899:18: E201 whitespace after '['
lib/ansible/modules/packaging/os/freebsdport.py:899:25: E202 whitespace before ']'
lib/ansible/modules/packaging/os/freebsdport.py:916:51: E201 whitespace after '['
lib/ansible/modules/packaging/os/freebsdport.py:916:84: E202 whitespace before ']'
lib/ansible/modules/packaging/os/freebsdport.py:920:51: E201 whitespace after '['
lib/ansible/modules/packaging/os/freebsdport.py:920:115: E202 whitespace before ']'
lib/ansible/modules/packaging/os/freebsdport.py:940:51: E201 whitespace after '['
lib/ansible/modules/packaging/os/freebsdport.py:940:77: E202 whitespace before ']'
lib/ansible/modules/packaging/os/freebsdport.py:943:1: W293 blank line contains whitespace
lib/ansible/modules/packaging/os/freebsdport.py:944:1: W293 blank line contains whitespace
lib/ansible/modules/packaging/os/freebsdport.py:947:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:947:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:948:18: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:948:20: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:951:26: E201 whitespace after '['
lib/ansible/modules/packaging/os/freebsdport.py:951:85: E202 whitespace before ']'
lib/ansible/modules/packaging/os/freebsdport.py:953:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:953:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:957:20: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:957:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:961:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:961:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:965:20: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:965:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:969:18: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:969:20: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:973:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:973:27: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:978:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:978:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:983:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:983:27: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:988:35: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:988:37: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:993:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:993:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:998:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:998:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/freebsdport.py:1035:12: E714 test for object identity should be 'is not'
lib/ansible/modules/packaging/os/freebsdport.py:1049:1: W391 blank line at end of file

The test ansible-test sanity --test pylint [?] failed with the following errors:

lib/ansible/modules/packaging/os/freebsdport.py:702:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/packaging/os/freebsdport.py:943:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/packaging/os/freebsdport.py:944:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/packaging/os/freebsdport.py:1049:0: trailing-newlines Trailing newlines

The test ansible-test sanity --test validate-modules [?] failed with the following errors:

lib/ansible/modules/packaging/os/freebsdport.py:0:0: E105 GPLv3 license header not found
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E305 DOCUMENTATION.version_added: required key not provided @ data['version_added']. Got None
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E307 version_added should be 2.5. Currently 0.0
lib/ansible/modules/packaging/os/freebsdport.py:178:16: E313 RETURN is not valid YAML
lib/ansible/modules/packaging/os/freebsdport.py:202:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/packaging/os/freebsdport.py:203:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/packaging/os/freebsdport.py:204:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/packaging/os/freebsdport.py:205:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Nov 9, 2017
@ansibot
Copy link
Contributor
ansibot commented Nov 9, 2017

The test ansible-test sanity --test validate-modules [?] failed with the following errors:

lib/ansible/modules/packaging/os/freebsdport.py:0:0: E319 RETURN.deinstalled_ports.type: not a valid value for dictionary value @ data['type']. Got 'list of strings'
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E319 RETURN.installed_ports.type: not a valid value for dictionary value @ data['type']. Got 'list of strings'
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E319 RETURN.set_options.type: not a valid value for dictionary value @ data['type']. Got 'list of strings'
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E319 RETURN.state.type: not a valid value for dictionary value @ data['type']. Got 'string or null'
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E319 RETURN.traceback.type: not a valid value for dictionary value @ data['type']. Got 'list of strings'
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E319 RETURN.unset_options.type: not a valid value for dictionary value @ data['type']. Got 'list of strings'

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Nov 9, 2017
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Nov 9, 2017
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Nov 10, 2017
@ansibot
Copy link
Contributor
ansibot commented Nov 10, 2017

@AnderEnder @DJMuggs @JoergFiedler @KimNorgaard @L2G @Akasurde @albertomurillo @alxgu @andrew-d @andytom @barnabycourt @berenddeboer @berenddeschouwer @brian-brazil @brontitall @danieljaouen @dermute @dinoocch @eest @elasticdog @enriclluelles @evgkrsk @FlossWare @hacosta @ignatenkobrain @indrajitr @jasperla @jcftang @jirutka @jtyr @jvantuyl @kahowell @kbrebanov @matze @mavit @melodous @mgwilliams @pmakowski @robinro @sashka @scathatheworm @skinp @sysadmind @szinck @tdtrask @the-maldridge @troy2914 @vaygr @verm666 @vincentvdk @vritant @wltjr

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 10, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 18, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Jan 29, 2018
@hartzell
Copy link

Hi @basarevych!

Thanks for submitting this PR, it could be really useful if/when it merges!

I have a couple of questions:

  • Are you still working on this?

  • Do you have any plans to update this to support flavors?

  • Have you considered breaking out the options setting into a separate module? I prefer to set all of my options in /etc/make.conf and not have to worry whether a port installs a module as a dependency before I install it explicitly.

    I believe that with your implementation I'd have to unwind/flatten the dependency tree of all of the things that I want to install and ensure that I installed things from the bottom up.

    E.g. If I know that e.g. devel/git is eventually going to pull in security/p5-GSSAPI and I know that I need to set GSSAPI_MIT and unset GSSAPI_BASE and GSSAPI_HEIMDAL then with your approach I'd need to install security/p5-GSSAPI explicitly. This has two drawbacks:

    • it's fragile
    • security/p5-GSSAPI ends up being marked not automatic and avoids autoremoval.

I understand that nothing that you've done here prevents me from modifying /etc/make.conf on my own before calling your module, but it would be handy to have an ansible module to manage it.

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 18, 2018
@basarevych
Copy link
Author

@hartzell Hi, yes, I am still working on it or more like just using it as it has already everything I wanted it to have.

The module has its own repo: https://github.com/basarevych/freebsdport so you can use it before (if ever) it is merged

For FLAVORs, see the new last example - you can set any make variable during build now.

Configuration is already a separate step (optionally). And you don't need to flatten anything, in your example you just need to add these two steps to your playbook:

- freebsdport:
    name: security/p5-GSSAPI
    options: GSSAPI_MIT=on GSSAPI_BASE=off GSSAPI_HEIMDAL=off
    state: configured

And it will not install anything at this point. Then, sometimes later:

- freebsdport:
    name: devel/git
    state: latest

And it will install git and all the dependencies, picking up the options, as these are just make variables

@ansibot
Copy link
Contributor
ansibot commented Jun 18, 2018

The test ansible-test sanity --test pylint [explain] failed with 11 errors:

lib/ansible/modules/packaging/os/freebsdport.py:365:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.
lib/ansible/modules/packaging/os/freebsdport.py:365:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.
lib/ansible/modules/packaging/os/freebsdport.py:368:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.
lib/ansible/modules/packaging/os/freebsdport.py:368:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.
lib/ansible/modules/packaging/os/freebsdport.py:371:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.
lib/ansible/modules/packaging/os/freebsdport.py:371:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.
lib/ansible/modules/packaging/os/freebsdport.py:483:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.
lib/ansible/modules/packaging/os/freebsdport.py:483:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.
lib/ansible/modules/packaging/os/freebsdport.py:656:0: anomalous-backslash-in-string Anomalous backslash in string: '\.'. String constant might be missing an r prefix.
lib/ansible/modules/packaging/os/freebsdport.py:675:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.
lib/ansible/modules/packaging/os/freebsdport.py:675:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.

The test ansible-test sanity --test validate-modules [explain] failed with 6 errors:

lib/ansible/modules/packaging/os/freebsdport.py:0:0: E305 DOCUMENTATION.options.variables.requied: extra keys not allowed @ data['options']['variables']['requied']. Got False
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E307 version_added should be 2.7. Currently 2.5
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E325 argument_spec for "cron" defines type="bool" but documentation does not
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E325 argument_spec for "ignore_vulnerabilities" defines type="bool" but documentation does not
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E325 argument_spec for "include_deps" defines type="bool" but documentation does not
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E325 argument_spec for "refresh_tree" defines type="bool" but documentation does not

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jun 18, 2018
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jun 18, 2018
@ansibot
Copy link
Contributor
ansibot commented Jun 18, 2018

The test ansible-test sanity --test pylint [explain] failed with 11 errors:

lib/ansible/modules/packaging/os/freebsdport.py:365:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.
lib/ansible/modules/packaging/os/freebsdport.py:365:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.
lib/ansible/modules/packaging/os/freebsdport.py:368:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.
lib/ansible/modules/packaging/os/freebsdport.py:368:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.
lib/ansible/modules/packaging/os/freebsdport.py:371:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.
lib/ansible/modules/packaging/os/freebsdport.py:371:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.
lib/ansible/modules/packaging/os/freebsdport.py:483:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.
lib/ansible/modules/packaging/os/freebsdport.py:483:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.
lib/ansible/modules/packaging/os/freebsdport.py:656:0: anomalous-backslash-in-string Anomalous backslash in string: '\.'. String constant might be missing an r prefix.
lib/ansible/modules/packaging/os/freebsdport.py:675:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.
lib/ansible/modules/packaging/os/freebsdport.py:675:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/packaging/os/freebsdport.py:0:0: E307 version_added should be 2.7. Currently 2.5
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E325 argument_spec for "cron" defines type="bool" but documentation does not
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E325 argument_spec for "ignore_vulnerabilities" defines type="bool" but documentation does not
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E325 argument_spec for "include_deps" defines type="bool" but documentation does not
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E325 argument_spec for "refresh_tree" defines type="bool" but documentation does not

click here for bot help

@ansibot
Copy link
Contributor
ansibot commented Jun 18, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 8 errors:

lib/ansible/modules/packaging/os/freebsdport.py:0:0: E325 argument_spec for "cron" defines type="bool" but documentation does not
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E325 argument_spec for "ignore_vulnerabilities" defines type="bool" but documentation does not
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E325 argument_spec for "include_deps" defines type="bool" but documentation does not
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E325 argument_spec for "refresh_tree" defines type="bool" but documentation does not
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E326 Value for "choices" from the argument_spec ([]) for "cron" does not match the documentation ([True, False])
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E326 Value for "choices" from the argument_spec ([]) for "ignore_vulnerabilities" does not match the documentation ([True, False])
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E326 Value for "choices" from the argument_spec ([]) for "include_deps" does not match the documentation ([True, False])
lib/ansible/modules/packaging/os/freebsdport.py:0:0: E326 Value for "choices" from the argument_spec ([]) for "refresh_tree" does not match the documentation ([True, False])

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 18, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 26, 2018
@dagwieers dagwieers added the bsd BSD community label Jan 18, 2019
@ansibot ansibot added the packaging Packaging category label Feb 19, 2019
@basarevych basarevych closed this Jun 23, 2019
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bsd BSD community community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. packaging Packaging category stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@basarevych @ansibot @hartzell @dagwieers @samdoran
0