8000 utils: handle FileExistsError by Akasurde · Pull Request #1419 · ansible/ansible-runner · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

utils: handle FileExistsError #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

utils: handle FileExistsError #1419

wants to merge 1 commit into from

Conversation

Akasurde
Copy link
Member
SUMMARY
  • In open_fifo_write, use existing FIFO file path if already exists

Fixes: #407

Signed-off-by: Abhijeet Kasurde Akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request

@Akasurde Akasurde requested a review from a team as a code owner February 28, 2025 00:32
@Akasurde
utils: handle FileExistsError
3390893 
* In open_fifo_write, use existing FIFO file path if already exists

Fixes: ansible#407

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
Shrews
Shrews reviewed Apr 1, 2025
View reviewed changes
Copy link
Contributor
@Shrews Shrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this fixing a particular issue? The FIFO is being created in the artifact directory, which should be unique for each run, so I would assume this check to be unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shrews Shrews Shrews left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FileExistsError on rc.prepare()
2 participants
@Akasurde @Shrews
0