8000 Log and ignore malformed plugin doc string. by cidrblock · Pull Request #1944 · ansible/ansible-navigator · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Log and ignore malformed plugin doc string. #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2025
Merged

Log and ignore malformed plugin doc string. #1944

merged 2 commits into from
Apr 8, 2025

Conversation

cidrblock
Copy link
Collaborator
@cidrblock cidrblock commented Apr 8, 2025 •
edited
Loading

Handle a case where the doc is a string and not a dictionary.

Fixes: #1943
Related: oVirt/ovirt-ansible-collection#760

Here is the additional log information:

2025-04-08T14:34:37.777771+00:00 ERROR 'ansible_navigator.actions.collections._get_collection_plugins_details' Error getting short name from plugin doc /usr/share/ansible/collections/ansible_collections/redhat/rhv/plugins/test/ovirt_proxied_check.py
Traceback (most recent call last):
  File "/home/bthornto/github/ansible-navigator/src/ansible_navigator/actions/collections.py", line 655, in _get_collection_plugins_details
    short_name = plugin["doc"][plugin_type]
                 ~~~~~~~~~~~~~^^^^^^^^^^^^^
TypeError: string indices must be integers, not 'str'
2025-04-08T14:34:37.779031+00:00 DEBUG 'ansible_navigator.actions.collections._get_collection_plugins_details' error was string indices must be integers, not 'str'
2025-04-08T14:34:37.779118+00:00 DEBUG 'ansible_navigator.actions.collections._get_collection_plugins_details' {'doc': 'Check if un URL will be accessed through a proxy', 'examples': None, 'returndocs': None, 'metadata': None}
2025-04-08T14:34:37.909855+00:00 DEBUG 'ansible_navigator.runner.base.__del__' delete temporary ansible-runner private_data_dir at path /tmp/ansible-navigator_s9v1d7e6

@cidrblock cidrblock requested a review from a team as a code owner April 8, 2025 14:39
@github-actions github-actions bot added the bug Researched, reproducible, committed to fix label Apr 8, 2025
@cidrblock cidrblock merged commit 62cf127 into ansible:main Apr 8, 2025
14 of 17 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in 🧰 devtools project board Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatakshiiii shatakshiiii shatakshiiii approved these changes

Assignees
No one assigned
Labels
bug Researched, reproducible, committed to fix
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Traceback with collections
2 participants
@cidrblock @shatakshiiii
0