8000 Update the createGroup command to use <enter> rather than click by hendersonreed · Pull Request #367 · ansible/ansible-hub-ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update the createGroup command to use <enter> rather than click #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2021
Merged

Update the createGroup command to use <enter> rather than click #367

merged 1 commit into from
Apr 22, 2021

Conversation

hendersonreed
Copy link
Contributor

To verify AAH-229 (handle in the "create group" modal), I've updated the createGroup command to use to submit the form rather than click the button on the modal.

I also removed a redundant call to cy.server() in the middle of the command.

@hendersonreed hendersonreed merged commit 4c2232f into master Apr 22, 2021
@hendersonreed hendersonreed deleted the qe/aah-229-handle-enter-in-group-create branch April 22, 2021 18:01
@hendersonreed hendersonreed added the backport-4.2 This PR should be backported to stable-4.2 (1.2) label Apr 22, 2021
@patchback
Copy link
patchback bot commented Apr 22, 2021 •
edited
Loading

Backport to stable-4.2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.2/4c2232f310f544e22f59efd56b523999807cce55/pr-367

Backported as #368

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 22, 2021
Update the createGroup command to use <enter> rather than click (#367)
145400e 
(cherry picked from commit 4c2232f)
@patchback patchback bot mentioned this pull request Apr 22, 2021
Merged
@hendersonreed hendersonreed added the backport-4.3 This PR should be backported to stable-4.3 (2.0) label Apr 22, 2021
@patchback
Copy link
patchback bot commented Apr 22, 2021 •
edited
Loading

Backport to stable-4.3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.3/4c2232f310f544e22f59efd56b523999807cce55/pr-367

Backported as #369

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 22, 2021
Update the createGroup command to use <enter> rather than click (#367)
73f859d 
(cherry picked from commit 4c2232f)
@patchback patchback bot mentioned this pull request Apr 22, 2021
Merged
newswangerd pushed a commit that referenced this pull request Apr 22, 2021
@patchback
Update the createGroup command to use <enter> rather than click (#367) (
819b68e 
#368)

(cherry picked from commit 4c2232f)

Co-authored-by: Henderson Hummel <hhummel@redhat.com>
newswangerd pushed a commit that referenced this pull request Apr 22, 2021
@patchback
Update the createGroup command to use <enter> rather than click (#367) (
086b1f6 
#369)

(cherry picked from commit 4c2232f)

Co-authored-by: Henderson Hummel <hhummel@redhat.com>
@ZitaNemeckova ZitaNemeckova added backported-4.2 This PR has been backported to stable-4.2 (1.2) backported-4.3 This PR has been backported to stable-4.3 (2.0) labels Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironfroggy ironfroggy ironfroggy approved these changes

@himdel himdel Awaiting requested review from himdel

@newswangerd newswangerd Awaiting requested review from newswangerd

@ZitaNemeckova ZitaNemeckova Awaiting requested review from ZitaNemeckova

Assignees
No one assigned
Labels
backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.3 This PR should be backported to stable-4.3 (2.0) backported-4.2 This PR has been backported to stable-4.2 (1.2) backported-4.3 This PR has been backported to stable-4.3 (2.0)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hendersonreed @ironfroggy @ZitaNemeckova
0