8000 Add ability to install local collection or role by ssbarnea · Pull Request #69 · ansible/ansible-compat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add ability to install local collection or role #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2021
Merged

Add ability to install local collection or role #69

merged 1 commit into from
Sep 6, 2021

Conversation

ssbarnea
Copy link
Member
@ssbarnea ssbarnea commented Sep 4, 2021
  • adds install_local parameter to prepare_environment(), defaulting to False
  • install local role or collection only when local_install is enabled

Fixes: #65

@ssbarnea ssbarnea requested a review from webknjaz as a code owner September 4, 2021 11:38
@ssbarnea ssbarnea added the bug Something isn't working label Sep 4, 2021
@ssbarnea ssbarnea force-pushed the fix/more branch 2 times, most recently from 813a4da to dcd2e50 Compare September 4, 2021 11:50
@ssbarnea ssbarnea force-pushed the fix/more branch 2 times, most recently from 87dd5eb to c68cef4 Compare September 4, 2021 15:22
@ssbarnea ssbarnea marked this pull request as draft September 5, 2021 08:59
@ssbarnea ssbarnea marked this pull request as ready for review September 5, 2021 16:29
@ssbarnea ssbarnea requested a review from tadeboro September 5, 2021 16:53
webknjaz
webknjaz reviewed Sep 5, 2021
View reviewed changes
webknjaz
webknjaz reviewed Sep 5, 2021
View reviewed changes
webknjaz
webknjaz reviewed Sep 5, 2021
View reviewed changes
tadeboro
tadeboro reviewed Sep 6, 2021
View reviewed changes
@ssbarnea ssbarnea force-pushed the fix/more branch 3 times, most recently from 74e1782 to 9e0c1a3 Compare September 6, 2021 08:57
tadeboro
tadeboro reviewed Sep 6, 2021
View reviewed changes
Copy link
@tadeboro tadeboro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test/collections/acme.goodies/acme-goodies-1.0.0.tar.gz is part of this PR on purpose? Apart from that, PR look good to me.

@ssbarnea ssbarnea requested a review from tadeboro September 6, 2021 09:30
@ssbarnea
Add ability to install local collection or role
d3b9337 
- adds install_local parameter to prepare_environment(), defaulting
  to False
- install local role or collection only when local_install is enabled

Fixes: #65
@ssbarnea ssbarnea enabled auto-merge (squash) September 6, 2021 09:53
@ssbarnea ssbarnea merged commit 90d4f51 into main Sep 6, 2021
@ssbarnea ssbarnea deleted the fix/more branch September 6, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

@tadeboro tadeboro tadeboro approved these changes

@greg-hellings greg-hellings Awaiting requested review from greg-hellings

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to install local collection or role
3 participants
@ssbarnea @tadeboro @webknjaz
0