8000 implement evpn_esi_multihome resource module by aida-shumburo · Pull Request #556 · ansible-collections/dellemc.enterprise_sonic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

implement evpn_esi_multihome resource module #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
May 30, 2025
Merged

implement evpn_esi_multihome resource module #556

merged 32 commits into from
May 30, 2025

Conversation

aida-shumburo
Copy link
Collaborator
@aida-shumburo aida-shumburo commented May 5, 2025 •
edited
Loading
SUMMARY

The customer is adopting ESI multihoming in our EVPN fabrics and are finding that some of the config elements not available in the Enterprise Sonic Ansible collection...
Specifically, the items highlighted in yellow, they're configuring these params using CLI right now:
!
evpn esi-multihoming <<<<<<< turns on multi-homing >>>>>>>>
mac-holdtime 1080 <<<<<<< can be reviewed per docs >>>>>>>>>
neigh-holdtime 1080 <<<<<<< can be reviewed per docs >>>>>>>>>
startup-delay 300 <<<<<<< delays advertising multi-homed interfaces until the switch control plane has been up for 5 minutes,
this ensures traffic does not get put on a switch that is not ready >>>>>>>>

GitHub Issues

N/A

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

sonic_evpn_esi_multihome

ADDITIONAL INFORMATION

Regression Report:
evpn_esi_multihome_regression_report.pdf

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document
How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran regression tests to ensure the options are implemented correctly
  • Ran Unit Tests in order to make sure that the options are implemented correctly

@aida-shumburo aida-shumburo added the new_resource_module This pull request adds a new resource module label May 13, 2025
@aida-shumburo aida-shumburo marked this pull request as ready for review May 14, 2025 21:09
stalabi1
stalabi1 requested changes May 15, 2025
View reviewed changes
@stalabi1
Copy link
Collaborator

New modules must now have a symlink:
In a workspace containing the contents of the current PR branch for evpn_esi_multihome:

Add entry in meta/runtime.yml.
cd plugins/action
ln -s sonic.py evpn_esi_multihome.py

@aida-shumburo aida-shumburo requested a review from stalabi1 May 16, 2025 17:24
@aida-shumburo aida-shumburo requested a review from stalabi1 May 20, 2025 17:03
stalabi1
stalabi1 reviewed May 20, 2025
View reviewed changes
stalabi1
stalabi1 reviewed May 20, 2025
View reviewed changes
stalabi1
stalabi1 reviewed May 20, 2025
View reviewed changes
stalabi1
stalabi1 reviewed May 20, 2025
View reviewed changes
stalabi1
stalabi1 reviewed May 20, 2025
View reviewed changes
stalabi1
stalabi1 reviewed May 20, 2025
View reviewed changes
stalabi1
stalabi1 reviewed May 20, 2025
View reviewed changes
stalabi1
stalabi1 reviewed May 20, 2025
View reviewed changes
stalabi1
stalabi1 reviewed May 20, 2025
View reviewed changes
@aida-shumburo aida-shumburo requested a review from stalabi1 May 20, 2025 22:17
stalabi1
stalabi1 requested changes May 20, 2025
View reviewed changes
tests/regression/roles/sonic_evpn_esi_multihome/tasks/tasks_template.yml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't commit the diff and check mode stuff that's just for the report

@aida-shumburo aida-shumburo requested a review from stalabi1 May 20, 2025 23:31
stalabi1
stalabi1 requested changes May 21, 2025
View reviewed changes
@aida-shumburo aida-shumburo requested a review from stalabi1 May 21, 2025 18:44
kerry-meyer
kerry-meyer approved these changes May 30, 2025
View reviewed changes
Copy link
Collaborator
@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed code changes and corresponding test results look good.

Thank your for implementing the EVPN ESI multihome resource module.

Approved.

@kerry-meyer kerry-meyer merged commit 61a81a6 into ansible-collections:main May 30, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerry-meyer kerry-meyer kerry-meyer approved these changes

@stalabi1 stalabi1 stalabi1 approved these changes

@awhaley-dell awhaley-dell Awaiting requested review from awhaley-dell

Assignees
No one assigned
Labels
new_resource_module This pull request adds a new resource module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aida-shumburo @stalabi1 @kerry-meyer
0