Added changes to support OSPFv3_interfaces ansible #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santhosh-kt
requested changes
May 9, 2025
|
|
||
| def get_ospfv3_interfaces_facts(self): | ||
| """ Get the 'facts' (the current configuration) | ||
| :rtype: A dictionary |
There was a problem hiding this comment.
Suggested change
| :rtype: A dictionary | |
| :rtype: A list |
|
|
||
| def set_config(self, existing_ospfv3_interfaces_facts): | ||
| """ Collect the configuration from the args passed to the module, | ||
| collect the current configuration (as a dict from facts) |
There was a problem hiding this comment.
Suggested change
| collect the current configuration (as a dict from facts) | |
| collect the current configuration (as a list from facts) |
|
|
||
| def set_state(self, want, have): | ||
| """ Select the appropriate function based on the state provided | ||
| :param want: the desired configuration as a dictionary |
There was a problem hiding this comment.
change dictionary to list on both 152-153
|
|
||
| new_config = get_new_config(new_commands, old_config, TEST_KEYS) | ||
|
|
||
| latest_config = self.new_cfg(new_config) |
There was a problem hiding this comment.
Suggested change
| latest_config = self.new_cfg(new_config) | |
| new_config = self.new_cfg(new_config) |
There was a problem hiding this comment.
replace 'latest_config' in below follow ups as well.
|
|
||
| self.facts_edit_config.side_effect = self.facts_side_effect | ||
| self.config_edit_config.side_effect = self.config_side_effect | ||
| self.utils_edit_config.side_effect = self.facts_side_effect |
There was a problem hiding this comment.
Suggested change
| self.utils_edit_config.side_effect = self.facts_side_effect | |
| self.utils_edit_config.side_effect = self.config_side_effect |
| DOCUMENTATION = """ | ||
| --- | ||
| module: sonic_ospfv3_interfaces | ||
| version_added: '3.1.0' |
There was a problem hiding this comment.
Suggested change
| version_added: '3.1.0' | |
| version_added: '3.1.0' | |
| notes: | |
| - Supports C(check_mode). | |
| - Tested against Enterprise SONiC Distribution by Dell Technologies. |
santhosh-kt
requested changes
May 27, 2025
Comment on lines
7
to
23
| ############################################# | ||
| # WARNING # | ||
| ############################################# | ||
| # | ||
| # This file is auto generated by the resource | ||
| # module builder playbook. | ||
| # | ||
| # Do not edit this file manually. | ||
| # | ||
| # Changes to this file will be over written | ||
| # by the resource module builder. | ||
| # | ||
| # Changes should be made in the model used to | ||
| # generate this file or in the resource module | ||
| # builder template. | ||
| # | ||
| ############################################# |
There was a problem hiding this comment.
Suggested change
| ############################################# | |
| # WARNING # | |
| ############################################# | |
| # | |
| # This file is auto generated by the resource | |
| # module builder playbook. | |
| # | |
| # Do not edit this file manually. | |
| # | |
| # Changes to this file will be over written | |
| # by the resource module builder. | |
| # | |
| # Changes should be made in the model used to | |
| # generate this file or in the resource module | |
| # builder template. | |
| # | |
| ############################################# |
| ansible_facts['ansible_network_resources'].update(facts) | ||
| return ansible_facts | ||
|
|
||
| def render_config(self, spec, conf): |
There was a problem hiding this comment.
This function returns same config.
Hence remove this and also change line 56 to 58 as objs.append(ospfv3_interface_config)
| if intf_name == "eth0": | ||
| continue | ||
|
|
||
| ospf = None |
There was a problem hiding this comment.
Suggested change
| ospf = None |
| if ipv6: | ||
| ospf_int = ipv6.get('openconfig-ospfv3-ext:ospfv3', {}) | ||
| if ospf_int: | ||
| # for name in ospf_int.get('config', []): |
There was a problem hiding this comment.
Suggested change
| # for name in ospf_int.get('config', []): |
| @@ -0,0 +1,599 @@ | |||
| #!/usr/bin/python | |||
| # -*- coding: utf-8 -*- | |||
| # Copyright 2024 Dell Inc. or its subsidiaries. All Rights Reserved | |||
There was a problem hiding this comment.
Suggested change
| # Copyright 2024 Dell Inc. or its subsidiaries. All Rights Reserved | |
| # Copyright 2025 Dell Inc. or its subsidiaries. All Rights Reserved |
Comment on lines
2
to
4
| - name: "Debug" | ||
| ansible.builtin.debug: | ||
|
|
There was a problem hiding this comment.
Suggested change
| - name: "Debug" | |
| ansible.builtin.debug: |
Comment on lines
232
to
234
|
|
||
|
|
||
|
|
| - no router ospfv3 | ||
|
|
||
| sonic_ospfv3_interfaces_tests: | ||
| - name: test_case_01 |
There was a problem hiding this comment.
Add a blank line between each testcases for more clarity
| del_config.append({'name': intf_name}) | ||
| return add_config, del_config | ||
|
|
||
| def get_create_ospf_interfaces_requests(self, commands, have): |
There was a problem hiding this comment.
Remove commented lines.
| description: | ||
| - Configure OSPFv3 transmit delay (1 to 65535). | ||
| type: int | ||
| bfd: |
There was a problem hiding this comment.
move bfd next to area_id for alphabetical order and arrange all attributes in alphabetical order.
There was a problem hiding this comment.
so does bfd_profile before enable.
|
and update ospfv3_interface details in meta/runtime.yml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
GitHub Issues
List the GitHub issues impacted by this PR. If no Github issues are affected, please indicate this with "N/A".
ISSUE TYPE
COMPONENT NAME
OUTPUT
ADDITIONAL INFORMATION
Checklist:
How Has This Been Tested?
ansible_log.txt
regression-2025-03-24-12-36-47.pdf