Creating standard acl in eos using replaced state #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for update acls.py, _state_replaced function doesn't take parameter "standard" to create standard acl. As a result, only extended acl is created. Updated the code to fix this issue.
Fixed the indent
for more information, see https://pre-commit.ci
Update indentation
|
@chanfoong2002 can you please add tests to validate you change and also add a changelog, you can refer previous merged PR as an Example! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
"replaced" state is not taking "standard" as parameters in ansible playbook. As a result only extended acl will be crated.
This fix will allow "standard: True" taken as input.
Fix #378
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
arista.eos.eos_acls
ADDITIONAL INFORMATION
Tested working in my environment.