8000 Update win_xml.ps1 by owadestig · Pull Request #632 · ansible-collections/community.windows · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ community.windows Public

Update win_xml.ps1 #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update win_xml.ps1 #632

wants to merge 1 commit into from

Conversation

owadestig
Copy link

Bugfix for removing win_xml attribute.

SUMMARY

See issue #631

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_xml

ADDITIONAL INFORMATION

See issue.

@owadestig
Update win_xml.ps1
55171d5 
Bugfix for removing win_xml attribute.
Akasurde
Akasurde requested changes May 7, 2025
View reviewed changes
plugins/modules/win_xml.ps1
@@ -265,7 +265,7 @@ elseif ($type -eq "attribute") {
}
else {
# element node processing
if ($node.Name -eq $attribute ) {
if ($node.HasAttribute($attribute)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a changelog fragment. See this fragment as an example. Could you please add a test for this change? Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akasurde Akasurde Akasurde requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owadestig @Akasurde
0