8000 Feat/conversion v2 v3 by muffoltz · Pull Request #266 · ansforge/SAMU-Hub-Modeles · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feat/conversion v2 v3 #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Feat/conversion v2 v3 #266

wants to merge 15 commits into from

Conversation

muffoltz
Copy link
Contributor
@muffoltz muffoltz commented Apr 23, 2025 •
edited
Loading

@github-actions GitHub Actions
Copy link
github-actions bot commented Apr 23, 2025 •
edited
Loading

Coverage

Converter - python code coverage
FileStmtsMissCoverMissing
constants.py100100% 
converter.py24291%32–33
utils.py133397%25, 69, 79
cisu
   cisu_converter.py133695%92, 101, 136, 195, 216, 234
   utils.py160100% 
conversion_strategy
   cisu_conversion_strategy.py27196%37
   conversion_strategy.py60100% 
   health_conversion_strategy.py18855%13–14, 16–17, 22–25
versions
   base_message_converter.py521178%46–48, 57, 65, 68, 71, 74, 77, 80, 83
   create_case_health_converter.py165596%20, 66, 80, 128, 186
   reference_converter.py13561%7, 10, 13, 16, 19
versions/v1_v2
   constants.py170100% 
   utils.py410100% 
versions/v2_v3
   constants.py150100% 
TOTAL6704193% 

@github-actions GitHub Actions
Copy link

There is no coverage information present for the Files changed

Total Project Coverage 62.13% 🍏

Clemsazert
Clemsazert reviewed Apr 23, 2025
View reviewed changes
converter/converter/v2_v3/v2_v3_converter.py Outdated
output_json = copy.deepcopy(input_json)
if 'createCaseHealth' not in input_json.get('content', [{}])[0].get('jsonContent', {}).get('embeddedJsonContent', {}).get('message', {}):
raise ValueError("Input JSON must contain 'createCaseHealth' key")
del output_json['content'][0]['jsonContent']['embeddedJsonContent']['message']['createCaseHealth']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai l'impression qu'on peut factoriser cette partie entre le upgrade et le downgrade.

@github-actions GitHub Actions
Copy link

There is no coverage information present for the Files changed

Total Project Coverage 62.13% 🍏

romainfd
romainfd reviewed Apr 23, 2025
View reviewed changes
Copy link
Collaborator
@romainfd romainfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonne base ! Les maps pour les conversions permettent d'y voir clair dans les correspondances, c'est top je trouve !

converter/converter/v2_v3/v2_v3_converter.py Outdated
V3_TO_V2_QUALIFICATION_ORIGIN_MAPPING = {
"15":"15",
"116117":"116117",
"AUTOCOM":"null",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"null" est vraiment nécessaire (par rapport à None voire ne pas mettre la ligne) et une attente du modèle en v2 ?

@github-actions GitHub Actions
Copy link

There is no coverage information present for the Files changed

Total Project Coverage 62.13% 🍏

romainfd
romainfd approved these changes Apr 23, 2025
View reviewed changes
Copy link
Collaborator
@romainfd romainfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

There is no coverage information present for the Files changed

Total Project Coverage 62.13% 🍏

2 similar comments
@github-actions GitHub Actions
Copy link

There is no coverage information present for the Files changed

Total Project Coverage 62.13% 🍏

@github-actions GitHub Actions
Copy link

There is no coverage information present for the Files changed

Total Project Coverage 62.13% 🍏

@muffoltz muffoltz force-pushed the feat/conversion-v2-v3 branch from 72dc6cf to 3669056 Compare May 12, 2025 12:39
@github-actions GitHub Actions
Copy link

There is no coverage information present for the Files changed

Total Project Coverage 62.13% 🍏

muffoltz added 15 commits May 14, 2025 09:54
@muffoltz muffoltz force-pushed the feat/conversion-v2-v3 branch from 3669056 to 284466d Compare May 16, 2025 08:26
@github-actions GitHub Actions
Copy link

There is no coverage information present for the Files changed

Total Project Coverage 62.13% 🍏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clemsazert Clemsazert Clemsazert left review comments

@romainfd romainfd romainfd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muffoltz @romainfd @Clemsazert
0