10000 Added binding to CanvasGroup.alpha by threeplus · Pull Request #98 · annulusgames/LitMotion · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added binding to CanvasGroup.alpha #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2024
Merged

Conversation

threeplus
Copy link
Contributor

CanvasGroup is not Graphic, other binding in LitMotionUGUIExtensions is not usable. A handy binding to CanvasGroup is added.

Added support to CanvasGroup.alpha
@nuskey8
Copy link
Member
nuskey8 commented Mar 16, 2024

Thank you for your PR.
Given the naming conventions for other extension methods, it seems like BindToCanvasGroupAlpha would be a better method name, but what about this one?

Update naming of BindToCanvasAlpha
@threeplus
Copy link
Contributor Author

Thanks for the naming suggestion. It is updated now.

@nuskey8 nuskey8 merged commit e21dd8c into annulusgames:main Mar 16, 2024
@nuskey8
Copy link
Member
nuskey8 commented Mar 16, 2024

Merged this PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0