8000 use actual regexp match instead of globs for tag matcher by zsedem · Pull Request #74 · anothrNick/github-tag-action · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

use actual regexp match instead of globs for tag matcher #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2020
Merged

use actual regexp match instead of globs for tag matcher #74

merged 1 commit into from
Aug 11, 2020

Conversation

zsedem
Copy link
Contributor
@zsedem zsedem commented Aug 6, 2020

The former implementation matched on versions like 25.0.0-RC1 or 1.3.4-M2

@zsedem
use actual regexp match instead of globs for tag matcher
56686c5 
The former implementation matched on versions like 25.0.0-RC1
or 1.3.4-M2
@fermoya
Copy link
Contributor
fermoya commented Aug 7, 2020

@zsedem , how are you handling tags for beta/alpha/rc versions? I'm trying to figure out how to use this action to automatize these. I'm also having the same problem as you for release tags, any one with "beta" or anything else in it is matched.

@zsedem
Copy link
Contributor Author
zsedem commented Aug 7, 2020 •
edited
Loading

We had some internal scala library release, which we tested on different services in production, these jars and repos had the versions of 26.0.0-RC1 ... 26.0.0-RC7 . All of these tags were created (pushed) manually from a branch (not master).
During this testing, someone created a fix for master applying it with #patch and the result was a new version called 26.0.1

Our opinion is that RC/Milestones/Beta releases should be created manually and any automatic release should ignore these.

So in the above case we would have expected 25.1.4 , because we had 25.1.3 before the fix

anothrNick
anothrNick approved these changes Aug 11, 2020
View reviewed changes
Copy link
Owner
@anothrNick anothrNick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@anothrNick anothrNick merged commit 83fbc06 into anothrNick:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anothrNick anothrNick anothrNick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zsedem @fermoya @anothrNick
0