Adding support for DEFAULT_BUMP=none #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eun
approved these changes
Apr 30, 2020
anothrNick
requested changes
May 5, 2020
entrypoint.sh
Outdated
| function default-bump { | ||
| if [ "$default_semvar_bump" == "none" ]; then | ||
| echo "Default bump was set to none. Skipping..." | ||
| return |
There was a problem hiding this comment.
Should this exit 0 here? Will a return quit the script early or just return from the function? (I'm not much of a bash expert)
There was a problem hiding this comment.
I suppose we could do exit 0 here. It comes down to if you want the rest of the script to run if the bump was disabled.
Looking through that, it seems like we probably don't want the rest of the script to run, so an exit will work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #56
By setting
DEFAULT_BUMP=none, automatic bumping will be disabled. You must provide#major/#minor/#patchto your git commits to trigger the version bump.