Update AppMidiManager.cpp #1101
Conversation
When switching MidiDevices the InputPort needs to be closed first, otherwise the new selected MidiDevice doesn't receive any Messages. This is at least the case on my android Device. AMidiInputPort_close(sMidiInputPort);
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
A lot of the code around this looks suspect to me because there's no error checking, so this may attempt to close a thing that wasn't successfully opened... but that's all pre-existing, and this definitely fixes one of the problems. If the rest of the sample looks anything like these two functions, this sample is probably due for a pretty significant overhaul :(
Thanks for the PR! Will merge, but I can't until you've signed the CLA.
add nullptr-check to AMidiInputPort_close()
When switching MidiDevices the InputPort needs to be closed first, otherwise the new selected MidiDevice doesn't receive any Messages. This is at least the case on my android Device.
AMidiInputPort_close(sMidiInputPort);