8000 codegen-units by andrewdavidmackenzie · Pull Request #819 · andrewdavidmackenzie/pigg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

codegen-units #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2025
Merged

codegen-units #819

merged 1 commit into from
Jan 22, 2025

Conversation

andrewdavidmackenzie
Copy link
Owner

Fixes #818

@andrewdavidmackenzie
Copy link
Owner Author

Timings of a clean build, on my mac M2

before:

  • cargo build --release 500.47s user 31.22s system 443% cpu 1:59.98 total
  • size target/release/piggui
    __TEXT __DATA __OBJC others dec hex
    7929856 32768 0 4297687040 4305649664 100a30000

after:

  • cargo build --release 431.64s user 27.42s system 377% cpu 2:01.72 total
  • size target/release/piggui
    __TEXT __DATA __OBJC others dec hex
    7651328 32768 0 4297441280 4305125376 1009b0000

So, about 300K of savings!

@codecov Codecov
Copy link
codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28%. Comparing base (575116b) to head (5a96f42).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@          Coverage Diff          @@
##           master   #819   +/-   ##
=====================================
  Coverage      28%    28%           
=====================================
  Files          47     47           
  Lines        5922   5922           
=====================================
  Hits         1631   1631           
  Misses       4291   4291
Flag Coverage Δ
unittests 28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewdavidmackenzie andrewdavidmackenzie merged commit 829765f into master Jan 22, 2025
17 checks passed
@andrewdavidmackenzie andrewdavidmackenzie deleted the pigg_818 branch January 22, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enabling codegen-units = 1 for reducing the binary size a bit more
1 participant
@andrewdavidmackenzie
0