This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(layout): Give Non-numeric flex values priority when media-dependent #11469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
:partyparrot: |
|
As with any changes to layout, we need to evaluate how the change affects the bundle size of the generated CSS. Can you please post the size numbers of before/after this PR for the angular-material.css and angular-material.min.css files? I'd love to say that we need some tests for this, however, I realize that our test setup for layouts is somewhere close to inadequate or non-existent. I'll try to do some manual testing on this soon. |
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number:
#11466
.layout-column > .flex-##, .layout-row > .flex-##Exists for numeric flex values, but do not for non-numeric flex values, (grow, auto, ect). This means that using a numeric flex value with a non-numeric flex value with a gt/sm/xs prefix will only render the numeric one, even if the media rules should prefer the non-numeric one.What is the new behavior?
Add more specific rules to the non-numeric mixins,
.layout-row/column > .#{$flexName}-nogrow/initial/auto/noshrink/grow/none.Does this PR in 8000 troduce a breaking change?
Other information