10000 docs: fix `takeUntilDestroyed` description's typo by bougwal · Pull Request #50134 · angular/angular · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix takeUntilDestroyed description's typo #50134

Closed
wants to merge 1 commit into from
Closed

docs: fix takeUntilDestroyed description's typo #50134

wants to merge 1 commit into from

Conversation

bougwal
Copy link
Contributor
@bougwal bougwal commented May 3, 2023

A tiny typo fix for the recently merged #50042

-I think the intention is for the verb not the adverb-

  • Docs have been updated

@pullapprove pullapprove bot requested a review from crisbeto May 3, 2023 21:29
@ngbot ngbot bot added this to the Backlog milestone May 3, 2023
t0k1dev
t0k1dev approved these changes May 4, 2023
View reviewed changes
Copy link
@t0k1dev t0k1dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍🏻

@pkozlowski-opensource pkozlowski-opensource removed the request for review from crisbeto May 4, 2023 07:02
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 4, 2023
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit adf3f6a.

pkozlowski-opensource pushed a commit that referenced this pull request May 4, 2023
@bougwal @pkozlowski-opensource
docs: fix takeUntilDestroyed description's typo (#50134)
68e6704 
PR Close #50134
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@t0k1dev t0k1dev t0k1dev approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@bougwal @pkozlowski-opensource @t0k1dev
0