8000 docs(docs-infra): fix the search-results label color on the dark theme. by JeanMeche · Pull Request #50083 · angular/angular · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(docs-infra): fix the search-results label color on the dark theme. #50083

Closed
wants to merge 1 commit into from
Closed

docs(docs-infra): fix the search-results label color on the dark theme. #50083

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

Theme color switching wasn't handled.

Before :
Screenshot 2023-04-30 at 00 21 55

After:
Screenshot 2023-04-30 at 00 21 39

@pullapprove pullapprove bot requested a review from AndrewKushnir April 29, 2023 22:25
@ngbot ngbot bot added this to the Backlog milestone Apr 29, 2023
@AndrewKushnir AndrewKushnir added aio: preview action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Apr 30, 2023
@github-actions
Copy link

Deployed aio for b1f289e to: https://ng-dev-previews-fw--pr-angular-angular-50083-xjs3ob5t.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@AndrewKushnir
Copy link
Contributor

@JeanMeche I've tried to reproduce the problem in Chrome using angular.io, but the titles on the search results seem to have correct color. I've opened angular.io, switched the theme and typed "view" in the search box. Could you please let me know if there are some extra steps that I need to take to reproduce the issue?

@AndrewKushnir AndrewKushnir added the needs: clarification This issue needs additional clarification from the reporter before the team can investigate. label Apr 30, 2023
@JeanMeche
Copy link
Member Author

@AndrewKushnir The issue happens on the search results on the Page not found.

For example: https://angular.io/common

AndrewKushnir
AndrewKushnir approved these changes Apr 30, 2023
View reviewed changes
Copy link
Contributor
@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for additional information 👍

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer needs: clarification This issue needs additional clarification from the reporter before the team can investigate. labels Apr 30, 2023
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 149e0c0.

pkozlowski-opensource pushed a commit that referenced this pull request May 2, 2023
@JeanMeche @pkozlowski-opensource
docs(docs-infra): fix the search-results label color on the dark them…
7f9b4d2 
…e. (#50083)

Theme color switching wasn't handled.

PR Close #50083
pkozlowski-opensource pushed a commit that referenced this pull request May 2, 2023
@JeanMeche @pkozlowski-opensource
docs(docs-infra): fix the search-results label color on the dark them…
33a560d 
…e. (#50083)

Theme color switching wasn't handled.

PR Close #50083
@JeanMeche JeanMeche deleted the docs/search-color branch May 2, 2023 11:58
@angular-automatic-lock-bot
Copy link
7DFA

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@JeanMeche @AndrewKushnir @pkozlowski-opensource
0