[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: simplify symbol tests format #59147

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: simplify symbol tests format #59147

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member
@crisbeto crisbeto commented Dec 11, 2024 •
edited
Loading

Switches the goldens for the symbol tests to be an array of strings, rather than an array of objects where each object only has a name property. This makes them more compact, easier to read and easier to avoid merge conflicts.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 11, 2024
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Dec 11, 2024
@ngbot ngbot bot added this to the Backlog milestone Dec 11, 2024
@crisbeto
build: simplify symbol tests format
169b364 
Switches the goldens for the symbol tests to be an array of strings, rather than an array of objects where each object only has a `name` property. This makes more compact, easier to read and easier to avoid merge conflicts.
@crisbeto crisbeto marked this pull request as ready for review December 11, 2024 12:54
@crisbeto crisbeto added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 11, 2024
@pullapprove pullapprove bot requested a review from josephperrott December 11, 2024 12:54
josephperrott
josephperrott approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member
@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I do want to note that this might up getting reworked overall with the upcoming toolchain change, but since we don't have any plans to add any other fields, moving to simple strings instead of a Symbol objects makes sense to me.

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
2 participants
@crisbeto @josephperrott