Initial state of a ui-date control is dirty (ng-dirty) causing the form state to be dirty as well #158

cs-NET · 2016-03-07T19:34:00Z

When you add ui-date directive to an input control the initial state of the control is dirty causing the form to be dirty as well. The control should only be dirty when the user changes the value.

https://plnkr.co/edit/QaM7f8uOn4mm11JiYAwr

cs-NET · 2016-03-07T19:55:06Z

I have tracked it down to the following code

          if (controller) {
            controller.$render();
            // Update the model with the value from the datepicker after parsed
            setVal(true); // *** this causes control to become dirty *** 
          }

alexanderchan · 2016-03-10T23:55:12Z

Thanks for tracking that down, I will not have much time to update this so PRs are welcome.

cs-NET · 2016-03-11T00:00:10Z

@alexanderchan I understand and will see if I can get to it next week

deggesim · 2016-06-17T13:31:35Z

+1

If I add controller.$setPristine(); after setVal(true); it seems to work.

Too simple?
`

zzsoszz · 2016-08-25T05:47:37Z

can you guys fix it ?

rbarinov · 2016-12-10T12:53:23Z

You can just add after lines:

	        if (controller) {
	          controller.$render();
	          // Update the model with the value from the datepicker after parsed
	          setVal(true);
	          controller.$setPristine();

additional code to set form $dirty field to false

	          if (controller.$$parentForm) {
	          	var anyOther = false;
		        for (var key in controller.$$parentForm) {
		        	if (key.indexOf('$') != 0) {
		        		var siblingController = controller.$$parentForm[key];

		        		if (siblingController.$dirty) {
		        			anyOther = true;
		        			break;
		        		}
		        	}
		        }

		        if (!anyOther) {
		          controller.$$parentForm.$setPristine()
		        }
		      }

faustimetal pushed a commit to Recras/ui-date that referenced this issue Feb 6, 2024

fix angular-ui#158 from original repo for ng-dirty bug

f4ae8cf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial state of a ui-date control is dirty (ng-dirty) causing the form state to be dirty as well #158

Initial state of a ui-date control is dirty (ng-dirty) causing the form state to be dirty as well #158

Initial state of a ui-date control is dirty (ng-dirty) causing the form state to be dirty as well #158

Initial state of a ui-date control is dirty (ng-dirty) causing the form state to be dirty as well #158

Comments