add VXLAN_PORT allow rules, do not block on ping to pod-gateway #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelnu
reviewed
Mar 30, 2025
bin/client_init.sh
Outdated
| @@ -65,7 +65,7 @@ ip addr | |||
| ip route | |||
|
|
|||
| # Check we can connect to the GATEWAY IP | |||
| ping -c "${CONNECTION_RETRY_COUNT}" "$GATEWAY_IP" | |||
| ping -c "${CONNECTION_RETRY_COUNT}" "$GATEWAY_IP" || true | |||
There was a problem hiding this comment.
Thanks for the PR
Could we keep the check? Perhaps by allowing ICMP in iptables
There was a problem hiding this comment.
let me check. using cilum with kube-proxy replacement I have not been able to ping.
not sure if that is related.
There was a problem hiding this comment.
This does work with Cilium's kube-proxy replacement aka the ping does work, so I'm not sue where you're running into issues?
|
I re-added the ping. Thanks @samip5 |
I think the problem, this author is encountering is that the networkpolicy that's included is pretty much every time applied. No matter how many times one tries to disable it in chart. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
If the VXLAN_PORT is set (e.g. 4789) additional firewall rules are required.
Additionally, the pod gateway ping in the client could not be performed (due to kubeproxy replacement) and therefore made optional. Connectivity issues are still detected either if the dhclient or the ping to gateway on VXLAN fails.
Benefits
Makes pod-gateway working in cilium