8000 Update smartConnect.py - privateKey initiated with privatekey instead… by amangoel1234 · Pull Request #58 · angel-one/smartapi-python · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update smartConnect.py - privateKey initiated with privatekey instead… #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

8000 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update smartConnect.py - privateKey initiated with privatekey instead… #58

wants to merge 1 commit into from

Conversation

amangoel1234
Copy link

… of apikey

In the initialization function,
privateKey variable is initiated with api key instead of privateKey.

@amangoel1234
Update smartConnect.py - privateKey initiated with privatekey instead…
ea96786 
… of apikey

In the initialization function,
privateKey variable is initiated with api key instead of privateKey.
@k4976
Copy link
k4976 commented Feb 6, 2025 •
edited
Loading

Your commit is of no use, bcoz it will create issue in request and user also need to pass api_key 2 times in the arguments.

k4976
k4976 reviewed Feb 6, 2025
View reviewed changes
Copy link
@k4976 k4976 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit is of no use, bcoz it will create issue when sending request and user need to pass api_key 2 times in the arguments.
Close this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k4976 k4976 k4976 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amangoel1234 @k4976
0