Finalize Recipe App #14
Conversation
Recipe-App: Setup migrations and model
Create Food list
There was a problem hiding this comment.
Hi team,
Good job so far! I see you put a lot of effort into this project. However, there are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- No linter errors
- Descriptive PR
- Good commit history.
Required Changes ♻️
Check the comments under the review.
- Kindly see the attached video where I demonstrated what issues are still with your application.
- Issue with creating the Recipe
- Issue with logging out of the application.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| end | ||
| end | ||
|
|
||
| def create |
There was a problem hiding this comment.
There is some issue with creating the recipes. Kindly refer to this videofor more clarification.
There was a problem hiding this comment.
Hi @eaesmat and @anasbassi,
Highlights
✔️ Descriptive PR
✔️ Passing linters
✔️ Good branch name
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| def create | ||
| @recipe = Recipe.new(recipe_params) | ||
| @recipe.user_id = params[:user_id] | ||
|
|
||
| respond_to do |format| | ||
| if @recipe.save | ||
| format.html { redirect_to user_recipes_path(@recipe), notice: 'Recipe was successfully created. ✅' } | ||
| format.json { render :show, status: :created, location: @recipe } | ||
| else | ||
| format.html { render :new, status: :unprocessable_entity } | ||
| format.json { render json: @recipe.errors, status: :unprocessable_entity } | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
-
When trying to create a recipe I get this error. The
cooking_timeseems to be properly permitted but does not appear in the record creation, so it is raising validation issues. Kindly fix that.
| protect_from_forgery with: :exception | ||
|
|
||
| before_action :configure_permitted_parameters, if: :devise_controller? | ||
|
|
There was a problem hiding this comment.
-
Despite being logged out I am still able to visit different pages. Kindly fix this. See example below.
logged out but can visit foods list page logged out but can visit recipe creation page You can fix this by adding the following helper to this
application_controller.rbfile. This way only signed-in users can visit certain parts of the app.before_action :authenticate_user!
There was a problem hiding this comment.
Hi @Team,
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉 🎉 🎉
Highlights
✔️ No linter errors
✔️ Github flow was correctly used
✔️ Good design
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
This PR contains the following changes