Order locations by container layer order #3858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
kzantow
reviewed
May 6, 2025
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the output of any locations field in the JSON output to always order locations within the same evidence group to have the same layer ordering as seen in the container image.
So for instance, say we have a package with the following locations:
/b @ layer 1 [primary evidence]/b @ layer 2 [primary evidence]/c @ layer 1 [supporting evidence]/c @ layer 2 [supporting evidence]/a @ layer 1 [no evidence]... this would also be the new sorting order.
This is a follow up to #3138 and #3855 so that consumers can now take the locations within each package location listing and be able to reason that earlier primary locations with the same path are overridden with later instances in the list with the same path (users can derive overriding precedence).
This change applies to:
.artifacts[].locations).artifacts.licenses[].locations).files)Closes #435
Type of change
Checklist