8000 Add setUpAsync() and tearDownAsync() by trowski · Pull Request #17 · amphp/phpunit-util · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add setUpAsync() and tearDownAsync() #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 1, 2020
Merged

Add setUpAsync() and tearDownAsync() #17

merged 4 commits into from
May 1, 2020

Conversation

trowski
Copy link
Member
@trowski trowski commented Apr 6, 2020

As requested by @prolic, this PR adds async versions of setUp() and tearDown(), aptly named setUpAsync() and tearDownAsync().

@trowski trowski requested a review from kelunik April 6, 2020 19:11
@trowski
Copy link
Member Author
trowski commented Apr 6, 2020

Question: Should setUpAsync() and tearDownAsync() require returning a promise, or should we use Amp\call()?

@prolic
Copy link
prolic commented Apr 6, 2020

Question: Should setUpAsync() and tearDownAsync() require returning a promise, or should we use Amp\call()?

I don't have any preference here.

@enumag
Copy link
enumag commented Apr 6, 2020

Neither do I.

@prolic
Copy link
prolic commented Apr 25, 2020

ping @trowski @kelunik

@enumag
Copy link
enumag commented Apr 25, 2020

With phpunit-util the tests can just yield right? So for consistency the same should be allowed for setUpAsync and tearDownAsync. So I'm leaning towards using call.

@prolic
Copy link
prolic commented Apr 26, 2020

perfect, merge and release? 👍

kelunik
kelunik approved these changes < 7EED a href="#pullrequestreview-400649137" class="js-timestamp Link--secondary" id="pullrequestreview-400649137-permalink"> Apr 27, 2020
View reviewed changes
@trowski trowski merged commit 99db640 into master May 1, 2020
@trowski trowski deleted the alt-13 branch May 1, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prolic prolic prolic approved these changes

@kelunik kelunik kelunik approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trowski @prolic @enumag @kelunik
0