8000 Added alternative Keys for Exclamation Mark and Question Mark by Johannes-bichler · Pull Request #13 · amarula/cutekeyboard · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added alternative Keys for Exclamation Mark and Question Mark #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

Johannes-bichler
Copy link

Hello,
I have been testing this keyboard for spanish usage, and have discovered that the upside down exclamation and question mark are missing, so I have added them.

@AndreaRicchi
Copy link
Contributor

@Johannes-bichler thank you for your contribution! Could you please rewrite the commit message in a better way; like:

SymbolLayout: add alternative keys for Spanish language

Added upside-down exclamation and question mark alternative keys for Spanish usage.

@AndreaRicchi AndreaRicchi self-requested a review April 23, 2024 07:37
Copy link
Contributor
@AndreaRicchi AndreaRicchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but fix the commit message please

Added upside-down Exclamation  and Question Mark alternative keys (Spanish usage)
@Johannes-bichler Johannes-bichler force-pushed the alternative-exclam-question branch from 4add410 to 32dcc91 Compare April 24, 2024 08:23
@Johannes-bichler
Copy link
Author

Thank you! The commit message was fixed.

@AndreaRicchi
Copy link
Contributor

LGTM

@AndreaRicchi AndreaRicchi merged commit 489e5db into amarula:main Apr 24, 2024
1 check failed
@dpurgin dpurgin deleted the alternative-exclam-question branch May 2, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0