Saner default saturation and sharpening for color correction #2776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the pointless default saturation boost of 0.5 when enabling color correction. - Also reduced the default sharpening value from 0.5 to 0.25, which provides a more visually natural result by minimizing haloing/ringing artifacts. The current sharpening method remains rudimentary, and higher values quickly turn into an eye sore.
zmerp
approved these changes
Mar 28, 2025
|
strange... i've been playing on 1.0 sharpening for a while and didn't notice much of haloing/ringing?... will check on those settings on pico a bit later |
|
Sorry for the wait, checked now, at least on linux with Intel IGPU i cannot find any difference between previous and new setting Either color correction is broken on intel gpus, or there's little to no difference |
Meister1593
reviewed
Jun 7, 2025
|
This might be stupid but are u sure you didn't forgot to enable color correction? |
I changed it around, it didn't seem to affect it at all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the pointless default saturation boost of 0.5 when enabling color correction.
Also reduced the default sharpening value from 0.5 to 0.25, which provides a more visually natural result by minimizing haloing/ringing artifacts. The current sharpening method remains rudimentary, and higher values quickly turn into an eye sore.