fix(client_openxr): Eye gaze orientation after recenter on Pico #2767
Conversation
There was a problem hiding this comment.
A bit after the headset has been removed and the screen shuts off, the headset will go to sleep. At least this is what happens on the Quest. This will trigger the XR session to destroy. Upon reactivation, the session and also the InteractionContext will be recreated. In this case the filed relative_head_orientation would be reset. have you tested this case?
alvr/client_openxr/src/stream.rs
Outdated
| let head_rot_inv = int_ctx.relative_head_orientation.conjugate().inverse(); | ||
|
|
||
| Pose { | ||
| orientation: head_rot_inv * pose.orientation, | ||
| position: head_rot_inv * pose.position, | ||
| } |
There was a problem hiding this comment.
For simplicity, instead of storing relative_head_orientation you could store the whole Pose. This allows you to directly use the Pose * Pose operator here
There was a problem hiding this comment.
This of course if the bug affects the whole pose, not just the orientation. but in the end we don't care much, as we just use the orientation for VRChat. Do the change anyway as it would simplify the code a bit
0180fec to
e4d3163
Compare
Pico OS just kills application in any case :) |
alvr/client_openxr/src/lib.rs
Outdated
| @@ -353,6 +353,10 @@ pub fn entry_point() { | |||
|
|
|||
| lobby.update_reference_space(); | |||
|
|
|||
| let relative_head_pose = interaction_context.read().relative_head_pose; | |||
| interaction_context.write().relative_head_pose = | |||
There was a problem hiding this comment.
You can keep the *= operator in theory
There was a problem hiding this comment.
error[E0368]: binary assignment operation
*=cannot be applied to typealvr_common::Pose
| let mut relative_head_pose = int_ctx.relative_head_pose; | ||
| relative_head_pose.position = Vec3::ZERO; | ||
|
|
||
| relative_head_pose * pose |
There was a problem hiding this comment.
I think you don't need to set the position to zero
There was a problem hiding this comment.
Stored position will break eye gaze position. That's why I've stored Quat in the first place.
There was a problem hiding this comment.
I see... well then you could undo the last commit, but keep the comment in the struct, and specify this detail
e4d3163 to
430363c
Compare
| pub action_set: xr::ActionSet, | ||
| pub button_actions: HashMap<u64, ButtonAction>, | ||
| pub hands_interaction: [HandInteraction; 2], | ||
| multimodal_handle: Option<MultimodalMeta>, | ||
| // Stores head orientation relative to the first created reference space. | ||
| // Used by head rotation correction for eye gazes on Pico. | ||
| pub relative_head_orientation: Quat, |
There was a problem hiding this comment.
Since this is a Pico-specific fix, let's prefix this field with pico_
Fixes #2740.