8000 Update Microphone Setup on Windows (installation-guide.md) by g0vman · Pull Request #2717 · alvr-org/ALVR · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update Microphone Setup on Windows (installation-guide.md) #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

g0vman
Copy link
Contributor
@g0vman g0vman commented Feb 20, 2025

title

@g0vman
Copy link
Contributor Author
g0vman commented Feb 20, 2025

Sorry, I just realized there's probably a format to follow for PRs and such

@zmerp
Copy link
Member
zmerp commented Feb 21, 2025

I think some parts would be better to be moved to the troubleshooting page. Opinions from the others?

@g0vman
Copy link
Contributor Author
g0vman commented Feb 22, 2025

I see what you mean, but the only real troubleshooting part is about removing the driver. I think it's better to leave it as it is to avoid going back and forth between pages. This way, if someone has a common problem with the microphone setup, we can simply redirect them to this part of the wiki and he redoes all the steps. If we find other specific issues, we can add them to the troubleshooting page.

@The-personified-devil
Copy link
Collaborator

Apart from that nitpick (I don't want to focus in so hard on this one piece of software that people might think alvr only works with it), these changes seem like a good idea and honestly better than having it under troubleshooting because this seems to happen semi-regularly and people being aware of the step to remedy it directly in the installation guide seems useful.

8000

Copy link
Member
@zmerp zmerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After all, I'm fine with this as is, no strong opinions

@The-personified-devil The-personified-devil merged commit 77697a8 into alvr-org:master Feb 24, 2025
8 checks passed
zmerp pushed a commit that referenced this pull request Mar 9, 2025
* Update Microphone Setup on Windows (installation-guide.md)

title

* directly fix nit

---------

Co-authored-by: Leonhard Saam <54042101+The-personified-devil@users.noreply.github.com>
zmerp pushed a commit that referenced this pull request Mar 11, 2025
* Update Microphone Setup on Windows (installation-guide.md)

title

* directly fix nit

---------

Co-authored-by: Leonhard Saam <54042101+The-personified-devil@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0