8000 Fix manylinux build not finding .so files by black-sliver · Pull Request #44 · alttpo/sni · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix manylinux build not finding .so files #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2024
Merged

Fix manylinux build not finding .so files #44

merged 2 commits into from
Nov 26, 2024

Conversation

black-sliver
Copy link
Contributor
  • Properly sets rpath for the manylinux build to find libappindicator
  • Patches libappindicator rpath so it finds libindicator
  • Update actions now that we use a newer manylinux image to build that can run current node

Tested here: https://github.com/black-sliver/sni/actions/runs/12026877741/job/33526733929#step:11:1 (ldd shows the correct paths))
and locally by running the build in a mostly-fresh Ubuntu 24.04 VM that has neither appindicator nor indicator installed.

@JamesDunne JamesDunne merged commit 6fb9d18 into alttpo:main Nov 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesDunne JamesDunne JamesDunne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@black-sliver @JamesDunne
0